Comment 2 for bug 1964389

Reviewed: https://review.opendev.org/c/openstack/os-brick/+/836055
Committed: https://opendev.org/openstack/os-brick/commit/e17bdf969b55aa8d51d7335274b19b3d58c2ed3c
Submitter: "Zuul (22348)"
Branch: master

commit e17bdf969b55aa8d51d7335274b19b3d58c2ed3c
Author: Gorka Eguileor <email address hidden>
Date: Wed Mar 9 12:27:30 2022 +0100

    NVMe-oF: Remove misleading exception from logs

    When disconnecting a non-replicated volume that uses the newer
    connection properties format we'll get some exception trace logs that
    could make us think that something went wrong, when in reality this is
    ok.

    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: DEBUG oslo.privsep.daemon [-] privsep: Exception during request[95eb2bcc-e4eb-4f5b-b823-56fd7aa338c6]: Unexpected error while running command.
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Command: blkid /dev/nvme0n2 -s TYPE -o value
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Exit code: 2
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Stdout: ''
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Stderr: '' {{(pid=988326) _process_cmd /usr/local/lib/python3.6/site-packages/oslo_privsep/daemon.py:481}}
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Traceback (most recent call last):
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/usr/local/lib/python3.6/site-packages/oslo_privsep/daemon.py", line 476, in _process_cmd
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: ret = func(*f_args, **f_kwargs)
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/usr/local/lib/python3.6/site-packages/oslo_privsep/priv_context.py", line 274, in _wrap
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: return func(*args, **kwargs)
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/opt/remote_brick/os_brick/privileged/rootwrap.py", line 197, in execute_root
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: return custom_execute(*cmd, shell=False, run_as_root=False, **kwargs)
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/opt/remote_brick/os_brick/privileged/rootwrap.py", line 146, in custom_execute
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: on_completion=on_completion, *cmd, **kwargs)
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/usr/local/lib/python3.6/site-packages/oslo_concurrency/processutils.py", line 441, in execute
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: cmd=sanitized_cmd)
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: oslo_concurrency.processutils.ProcessExecutionError: Unexpected error while running command.
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Command: blkid /dev/nvme0n2 -s TYPE -o value
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Exit code: 2
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Stdout: ''
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Stderr: ''

    This patch calls the command execution in a way that no longer shows
    such exception.

    Closes-Bug: #1964389
    Change-Id: I1c54e1ff3026cffe49b303f01e43d1b90d0bf3bc