os-brick

NVMe-oF: Shows misleading traceback

Bug #1964389 reported by Gorka Eguileor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-brick
Fix Released
Medium
Gorka Eguileor

Bug Description

When using the new nvmeof format of the connector properties with non replicated volumes we see a traceback on the logs when detaching, and it can be misleading, because people usually don't pay attention to the log level (DEBUG in this case) when seeing a traceback in the logs.

The detach works as intended and this is not an issue, but it would be nice not to see this traceback in the logs.

Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: DEBUG oslo.privsep.daemon [-] privsep: Exception during request[95eb2bcc-e4eb-4f5b-b823-56fd7aa338c6]: Unexpected error while running command.
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Command: blkid /dev/nvme0n2 -s TYPE -o value
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Exit code: 2
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Stdout: ''
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Stderr: '' {{(pid=988326) _process_cmd /usr/local/lib/python3.6/site-packages/oslo_privsep/daemon.py:481}}
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Traceback (most recent call last):
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/usr/local/lib/python3.6/site-packages/oslo_privsep/daemon.py", line 476, in _process_cmd
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: ret = func(*f_args, **f_kwargs)
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/usr/local/lib/python3.6/site-packages/oslo_privsep/priv_context.py", line 274, in _wrap
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: return func(*args, **kwargs)
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/opt/remote_brick/os_brick/privileged/rootwrap.py", line 197, in execute_root
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: return custom_execute(*cmd, shell=False, run_as_root=False, **kwargs)
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/opt/remote_brick/os_brick/privileged/rootwrap.py", line 146, in custom_execute
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: on_completion=on_completion, *cmd, **kwargs)
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/usr/local/lib/python3.6/site-packages/oslo_concurrency/processutils.py", line 441, in execute
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: cmd=sanitized_cmd)
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: oslo_concurrency.processutils.ProcessExecutionError: Unexpected error while running command.
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Command: blkid /dev/nvme0n2 -s TYPE -o value
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Exit code: 2
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Stdout: ''
Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Stderr: ''

Tags: nvme
Sofia Enriquez (lsofia-enriquez)
Changed in os-brick:
importance: Undecided → Medium
Sofia Enriquez (lsofia-enriquez)
Changed in os-brick:
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/os-brick/+/836055

Changed in os-brick:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (master)
Download full text (3.3 KiB)

Reviewed: https://review.opendev.org/c/openstack/os-brick/+/836055
Committed: https://opendev.org/openstack/os-brick/commit/e17bdf969b55aa8d51d7335274b19b3d58c2ed3c
Submitter: "Zuul (22348)"
Branch: master

commit e17bdf969b55aa8d51d7335274b19b3d58c2ed3c
Author: Gorka Eguileor <email address hidden>
Date: Wed Mar 9 12:27:30 2022 +0100

    NVMe-oF: Remove misleading exception from logs

    When disconnecting a non-replicated volume that uses the newer
    connection properties format we'll get some exception trace logs that
    could make us think that something went wrong, when in reality this is
    ok.

    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: DEBUG oslo.privsep.daemon [-] privsep: Exception during request[95eb2bcc-e4eb-4f5b-b823-56fd7aa338c6]: Unexpected error while running command.
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Command: blkid /dev/nvme0n2 -s TYPE -o value
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Exit code: 2
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Stdout: ''
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Stderr: '' {{(pid=988326) _process_cmd /usr/local/lib/python3.6/site-packages/oslo_privsep/daemon.py:481}}
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Traceback (most recent call last):
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/usr/local/lib/python3.6/site-packages/oslo_privsep/daemon.py", line 476, in _process_cmd
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: ret = func(*f_args, **f_kwargs)
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/usr/local/lib/python3.6/site-packages/oslo_privsep/priv_context.py", line 274, in _wrap
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: return func(*args, **kwargs)
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/opt/remote_brick/os_brick/privileged/rootwrap.py", line 197, in execute_root
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: return custom_execute(*cmd, shell=False, run_as_root=False, **kwargs)
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/opt/remote_brick/os_brick/privileged/rootwrap.py", line 146, in custom_execute
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: on_completion=on_completion, *cmd, **kwargs)
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: File "/usr/local/lib/python3.6/site-packages/oslo_concurrency/processutils.py", line 441, in execute
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: cmd=sanitized_cmd)
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: oslo_concurrency.processutils.ProcessExecutionError: Unexpected error while running command.
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Command: blkid /dev/nvme0n2 -s TYPE -o value
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Exit code: 2
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Stdout: ''
    Mar 09 11:14:42 localhost.localdomain nova-compute[988198]: Stderr: ''

    This ...

Read more...

Changed in os-brick:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 6.0.0

This issue was fixed in the openstack/os-brick 6.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.