Report actual request_spec when MaxRetriesExceeded raised
If a MaxRetriesExceeded exception is raised by
scheduler_utils.populate_retry then request_spec will be empty in the
exception handler[1], then _set_vm_state_and_notify method will just
put a empty dict as request_spec into the payload of notification[2].
It would make more sense if we report the actual value of request_spec
in the notification.
Reviewed: https:/ /review. openstack. org/310639 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=1a80c8899d5 41fe451afb030d5 011cf8c7543a3c
Committed: https:/
Submitter: Jenkins
Branch: master
commit 1a80c8899d541fe 451afb030d5011c f8c7543a3c
Author: Wenzhi Yu <wenzhi_yu@163.com>
Date: Thu Apr 28 10:32:44 2016 +0800
Report actual request_spec when MaxRetriesExceeded raised
If a MaxRetriesExceeded exception is raised by utils.populate_ retry then request_spec will be empty in the state_and_ notify method will just
scheduler_
exception handler[1], then _set_vm_
put a empty dict as request_spec into the payload of notification[2].
It would make more sense if we report the actual value of request_spec
in the notification.
[1]https:/ /github. com/openstack/ nova/blob/ 13.0.0. 0rc3/nova/ conductor/ manager. py#L382 /github. com/openstack/ nova/blob/ 13.0.0. 0rc3/nova/ scheduler/ utils.py# L109
[2]https:/
Simply moving the initialization of request_spec up one line before the
call to populate_retry should fix the issue.
Change-Id: I7c51f635d52f36 8c8df549f62024c bdf64a032b3
Closes-Bug: #1575998