The actual value of 'request_spec' should be reported when a MaxRetriesExceeded exception is raised

Bug #1575998 reported by Wenzhi Yu on 2016-04-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Low
Wenzhi Yu

Bug Description

If a MaxRetriesExceeded exception is raised by scheduler_utils.populate_retry then request_spec will be empty in the exception handler[1], then _set_vm_state_and_notify method will just put a empty dict as request_spec into the payload of notification[2]. It would make more sense if we report the actual value of request_spec in the notification.

[1]https://github.com/openstack/nova/blob/13.0.0.0rc3/nova/conductor/manager.py#L382
[2]https://github.com/openstack/nova/blob/13.0.0.0rc3/nova/scheduler/utils.py#L109

Simply moving the initialization of request_spec up one line before the call to populate_retry should fix the issue.

Wenzhi Yu (yuywz) on 2016-04-28
Changed in nova:
assignee: nobody → Wenzhi Yu (yuywz)

Fix proposed to branch: master
Review: https://review.openstack.org/310639

Changed in nova:
status: New → In Progress
melanie witt (melwitt) on 2016-09-29
Changed in nova:
importance: Undecided → Low

Reviewed: https://review.openstack.org/310639
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1a80c8899d541fe451afb030d5011cf8c7543a3c
Submitter: Jenkins
Branch: master

commit 1a80c8899d541fe451afb030d5011cf8c7543a3c
Author: Wenzhi Yu <wenzhi_yu@163.com>
Date: Thu Apr 28 10:32:44 2016 +0800

    Report actual request_spec when MaxRetriesExceeded raised

    If a MaxRetriesExceeded exception is raised by
    scheduler_utils.populate_retry then request_spec will be empty in the
    exception handler[1], then _set_vm_state_and_notify method will just
    put a empty dict as request_spec into the payload of notification[2].
    It would make more sense if we report the actual value of request_spec
    in the notification.

    [1]https://github.com/openstack/nova/blob/13.0.0.0rc3/nova/conductor/manager.py#L382
    [2]https://github.com/openstack/nova/blob/13.0.0.0rc3/nova/scheduler/utils.py#L109

    Simply moving the initialization of request_spec up one line before the
    call to populate_retry should fix the issue.

    Change-Id: I7c51f635d52f368c8df549f62024cbdf64a032b3
    Closes-Bug: #1575998

Changed in nova:
status: In Progress → Fix Released

This issue was fixed in the openstack/nova 15.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers