Raising NEW exception is bad practice, because we lose TraceBack.
So all places like:
except SomeException as e:
raise e
should be replaced by
except SomeException:
raise
If we are doing some other actions before reraising we should
store information about exception then do all actions and then
reraise it. This is caused by eventlet bug. It lost information
about exception if it switch threads.
Reviewed: https:/ /review. openstack. org/33614 github. com/openstack/ keystone/ commit/ f79ccf452b7a0cb f51c63adf259f46 896586dc16
Committed: http://
Submitter: Jenkins
Branch: master
commit f79ccf452b7a0cb f51c63adf259f46 896586dc16
Author: Sergey Vilgelm <email address hidden>
Date: Mon Jun 24 13:41:07 2013 +0400
Do not raise NEW exceptions
Raising NEW exception is bad practice, because we lose TraceBack.
So all places like:
except SomeException as e:
raise e
should be replaced by
except SomeException:
raise
If we are doing some other actions before reraising we should
store information about exception then do all actions and then
reraise it. This is caused by eventlet bug. It lost information
about exception if it switch threads.
fixes bug 1191730
Change-Id: I8dffc36ba57809 11dd57d7161d218 d0324af60b3