OpenStack Compute (nova)

  1. Bug #1191730
  2. Comment #5

Comment 5 for bug 1191730

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/34349
Committed: http://github.com/openstack/oslo-incubator/commit/31325752e1d202c95f65b8af0e656b283043f1cd
Submitter: Jenkins
Branch: master

commit 31325752e1d202c95f65b8af0e656b283043f1cd
Author: Sergey Vilgelm <email address hidden>
Date: Tue Jun 25 14:42:15 2013 +0400

    Do not raise NEW exceptions

    Raising NEW exception is bad practice, because we lose TraceBack.
    So all places like:

    except SomeException as e:
        raise e

    should be replaced by

    except SomeException:
        raise

    If we are doing some other actions before reraising we should
    store information about exception then do all actions and then
    reraise it. This is caused by eventlet bug. It lost information
    about exception if it switch threads.

    fixes bug 1191730

    Change-Id: I7bce659591c4c3e4bc41e12d7d8390128c30e2e4