commit c1e5e3352a71cc61ba9e7dba0d9048d8b766e2c0
Author: Nikola Dipanov <email address hidden>
Date: Wed Oct 10 13:47:26 2012 +0200
Fixes test_libvirtr spawn_with_network_info test
This patch fixes the LibvirtConnTestCase.test_spawn_with_network_info
test case that was reported as bug 1053572.
The new implementation of the test makes no assumptions about the raised
exceptions, and exercises the LibvirtDriver.spawn method completely.
The test has the network_info faked and the libvirt connection mocked out.
In addition. it also fixes the fake_network.FakeVIFDriver class used in
this test to return a LibvirtConfigGuestInterface instance with fake
values instead of just a dict. Also fixes some docstring inaccuracies
in the nova.libvirt.vif module that may have lead to the FakeVIFDrivers
wrong implementation before.
Reviewed: https:/ /review. openstack. org/14284 github. com/openstack/ nova/commit/ c1e5e3352a71cc6 1ba9e7dba0d9048 d8b766e2c0
Committed: http://
Submitter: Jenkins
Branch: master
commit c1e5e3352a71cc6 1ba9e7dba0d9048 d8b766e2c0
Author: Nikola Dipanov <email address hidden>
Date: Wed Oct 10 13:47:26 2012 +0200
Fixes test_libvirtr spawn_with_ network_ info test
This patch fixes the LibvirtConnTest Case.test_ spawn_with_ network_ info
test case that was reported as bug 1053572.
The new implementation of the test makes no assumptions about the raised
exceptions, and exercises the LibvirtDriver.spawn method completely.
The test has the network_info faked and the libvirt connection mocked out.
In addition. it also fixes the fake_network. FakeVIFDriver class used in estInterface instance with fake
this test to return a LibvirtConfigGu
values instead of just a dict. Also fixes some docstring inaccuracies
in the nova.libvirt.vif module that may have lead to the FakeVIFDrivers
wrong implementation before.
Fixes bug 1053572
Change-Id: Ie5b69a2269ab09 9267231329eae21 bd308fef835