libvirt test_spawn_with_network_info is broken

[Johannes Erdfelt]

While working on cleaning up poor uses of 'except Exception', I stumbled upon test_spawn_with_network_info.

The call to conn.spawn is failing because of a missing implementation of getLibVersion(), not because of the unexpected method call, or SHA1 type problems intended to be tested.

Creating an implementation of getLibVersion() gets to an unimplemented getCapabilities() call which is trickier.

I stopped at this point since it's not clear what the best fix is, or even if this test is still necessary.

I do know that the use of 'except Exception' is broken and hiding the fact the test is broken.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/14284

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/14284
Committed: http://github.com/openstack/nova/commit/c1e5e3352a71cc61ba9e7dba0d9048d8b766e2c0
Submitter: Jenkins
Branch: master

commit c1e5e3352a71cc61ba9e7dba0d9048d8b766e2c0
Author: Nikola Dipanov <email address hidden>
Date: Wed Oct 10 13:47:26 2012 +0200

    Fixes test_libvirtr spawn_with_network_info test

    This patch fixes the LibvirtConnTestCase.test_spawn_with_network_info
    test case that was reported as bug 1053572.

    The new implementation of the test makes no assumptions about the raised
    exceptions, and exercises the LibvirtDriver.spawn method completely.
    The test has the network_info faked and the libvirt connection mocked out.

    In addition. it also fixes the fake_network.FakeVIFDriver class used in
    this test to return a LibvirtConfigGuestInterface instance with fake
    values instead of just a dict. Also fixes some docstring inaccuracies
    in the nova.libvirt.vif module that may have lead to the FakeVIFDrivers
    wrong implementation before.

    Fixes bug 1053572

    Change-Id: Ie5b69a2269ab099267231329eae21bd308fef835