Comment 9 for bug 1991509

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860664
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/c10a2d8ec5fc1adc8bfec39c08f3455bdf7ce2dd
Submitter: "Zuul (22348)"
Branch: stable/zed

commit c10a2d8ec5fc1adc8bfec39c08f3455bdf7ce2dd
Author: Luis Tomas Bolivar <email address hidden>
Date: Fri Sep 30 20:13:49 2022 +0200

    Ensure lbs are properly configured for router gateway set/unset

    Before adding support for lbs with VIPs on the provider networks,
    there was no need to react to gateway chassis creation events, and
    nothing was done for its deletion. However, after adding the support
    for that, there is a need of properly handling the creation event
    for that type of port.

    For the loadbalancer VIPs on the provider network, processing the
    event and triggering the lb_creat_lrp_assoc_handler means that the
    information about the logical router will be added, i.e., the router
    is added to the loadbalancer external_ids as a lr_ref, while the
    loadbalancer is also added into the logical_router object
    (loadbalancer entry). In addition, the lb is also added to the logical
    switches connected to the router.

    For the loadbalancer VIPs on tenant networks (which should not be
    affected by the gateway port creation/deletion), this patch ensures
    the lb is not added to the logical switch representing the provider
    network that is connected to the router. Therefore differentiating
    between lrp ports which has gateway_chassis and the ones that don't,
    i.e., adding the lb to the switch when the lrp port is the one
    connecting a subnet with the router, and not doing so when it is the
    gateway port for the router to the provider network.

    Closes-Bug: #1991509

    Change-Id: Iddd96fd9015230b3dd75aa2182055cf43eb608c1
    (cherry picked from commit d889812f3c2deaf630892d65c90cdbafd4435d21)