[ovn-octavia-provider] router gateway unset + set breaks ovn lb connectivity

[Luis Tomas Bolivar]

The LogicalRouterPortEvent for gateway_chassis port are skip [1], however if ovn lb VIPs are on provider network, the create event needs to be handle so that the loadbalancer gets properly configured and added to the router

[1] https://opendev.org/openstack/ovn-octavia-provider/src/commit/acbf6e7f3e223c088582390475c84464bc27227d/ovn_octavia_provider/event.py#L39

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/858363
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/d889812f3c2deaf630892d65c90cdbafd4435d21
Submitter: "Zuul (22348)"
Branch: master

commit d889812f3c2deaf630892d65c90cdbafd4435d21
Author: Luis Tomas Bolivar <email address hidden>
Date: Fri Sep 30 20:13:49 2022 +0200

    Ensure lbs are properly configured for router gateway set/unset

    Before adding support for lbs with VIPs on the provider networks,
    there was no need to react to gateway chassis creation events, and
    nothing was done for its deletion. However, after adding the support
    for that, there is a need of properly handling the creation event
    for that type of port.

    For the loadbalancer VIPs on the provider network, processing the
    event and triggering the lb_creat_lrp_assoc_handler means that the
    information about the logical router will be added, i.e., the router
    is added to the loadbalancer external_ids as a lr_ref, while the
    loadbalancer is also added into the logical_router object
    (loadbalancer entry). In addition, the lb is also added to the logical
    switches connected to the router.

    For the loadbalancer VIPs on tenant networks (which should not be
    affected by the gateway port creation/deletion), this patch ensures
    the lb is not added to the logical switch representing the provider
    network that is connected to the router. Therefore differentiating
    between lrp ports which has gateway_chassis and the ones that don't,
    i.e., adding the lb to the switch when the lrp port is the one
    connecting a subnet with the router, and not doing so when it is the
    gateway port for the router to the provider network.

    Closes-Bug: #1991509

    Change-Id: Iddd96fd9015230b3dd75aa2182055cf43eb608c1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860664

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860665

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860666

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860667

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860668

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860776

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860665
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/4029128d8b650b1165fd22b89f1a9216fa2b9180
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 4029128d8b650b1165fd22b89f1a9216fa2b9180
Author: Luis Tomas Bolivar <email address hidden>
Date: Fri Sep 30 20:13:49 2022 +0200

    Ensure lbs are properly configured for router gateway set/unset

    Before adding support for lbs with VIPs on the provider networks,
    there was no need to react to gateway chassis creation events, and
    nothing was done for its deletion. However, after adding the support
    for that, there is a need of properly handling the creation event
    for that type of port.

    For the loadbalancer VIPs on the provider network, processing the
    event and triggering the lb_creat_lrp_assoc_handler means that the
    information about the logical router will be added, i.e., the router
    is added to the loadbalancer external_ids as a lr_ref, while the
    loadbalancer is also added into the logical_router object
    (loadbalancer entry). In addition, the lb is also added to the logical
    switches connected to the router.

    For the loadbalancer VIPs on tenant networks (which should not be
    affected by the gateway port creation/deletion), this patch ensures
    the lb is not added to the logical switch representing the provider
    network that is connected to the router. Therefore differentiating
    between lrp ports which has gateway_chassis and the ones that don't,
    i.e., adding the lb to the switch when the lrp port is the one
    connecting a subnet with the router, and not doing so when it is the
    gateway port for the router to the provider network.

    Closes-Bug: #1991509

    Change-Id: Iddd96fd9015230b3dd75aa2182055cf43eb608c1
    (cherry picked from commit d889812f3c2deaf630892d65c90cdbafd4435d21)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860664
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/c10a2d8ec5fc1adc8bfec39c08f3455bdf7ce2dd
Submitter: "Zuul (22348)"
Branch: stable/zed

commit c10a2d8ec5fc1adc8bfec39c08f3455bdf7ce2dd
Author: Luis Tomas Bolivar <email address hidden>
Date: Fri Sep 30 20:13:49 2022 +0200

    Ensure lbs are properly configured for router gateway set/unset

    Before adding support for lbs with VIPs on the provider networks,
    there was no need to react to gateway chassis creation events, and
    nothing was done for its deletion. However, after adding the support
    for that, there is a need of properly handling the creation event
    for that type of port.

    For the loadbalancer VIPs on the provider network, processing the
    event and triggering the lb_creat_lrp_assoc_handler means that the
    information about the logical router will be added, i.e., the router
    is added to the loadbalancer external_ids as a lr_ref, while the
    loadbalancer is also added into the logical_router object
    (loadbalancer entry). In addition, the lb is also added to the logical
    switches connected to the router.

    For the loadbalancer VIPs on tenant networks (which should not be
    affected by the gateway port creation/deletion), this patch ensures
    the lb is not added to the logical switch representing the provider
    network that is connected to the router. Therefore differentiating
    between lrp ports which has gateway_chassis and the ones that don't,
    i.e., adding the lb to the switch when the lrp port is the one
    connecting a subnet with the router, and not doing so when it is the
    gateway port for the router to the provider network.

    Closes-Bug: #1991509

    Change-Id: Iddd96fd9015230b3dd75aa2182055cf43eb608c1
    (cherry picked from commit d889812f3c2deaf630892d65c90cdbafd4435d21)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860667
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/4ab7616796ac2df247944e3ba0207bcd0e8dc7df
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 4ab7616796ac2df247944e3ba0207bcd0e8dc7df
Author: Luis Tomas Bolivar <email address hidden>
Date: Fri Sep 30 20:13:49 2022 +0200

    Ensure lbs are properly configured for router gateway set/unset

    Before adding support for lbs with VIPs on the provider networks,
    there was no need to react to gateway chassis creation events, and
    nothing was done for its deletion. However, after adding the support
    for that, there is a need of properly handling the creation event
    for that type of port.

    For the loadbalancer VIPs on the provider network, processing the
    event and triggering the lb_creat_lrp_assoc_handler means that the
    information about the logical router will be added, i.e., the router
    is added to the loadbalancer external_ids as a lr_ref, while the
    loadbalancer is also added into the logical_router object
    (loadbalancer entry). In addition, the lb is also added to the logical
    switches connected to the router.

    For the loadbalancer VIPs on tenant networks (which should not be
    affected by the gateway port creation/deletion), this patch ensures
    the lb is not added to the logical switch representing the provider
    network that is connected to the router. Therefore differentiating
    between lrp ports which has gateway_chassis and the ones that don't,
    i.e., adding the lb to the switch when the lrp port is the one
    connecting a subnet with the router, and not doing so when it is the
    gateway port for the router to the provider network.

    Closes-Bug: #1991509

    Change-Id: Iddd96fd9015230b3dd75aa2182055cf43eb608c1
    (cherry picked from commit d889812f3c2deaf630892d65c90cdbafd4435d21)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860776
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/56e8976b98107336df04283bd1eb2ed11c2da37a
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 56e8976b98107336df04283bd1eb2ed11c2da37a
Author: Luis Tomas Bolivar <email address hidden>
Date: Mon Oct 10 08:09:02 2022 +0200

    Ensure lbs are properly configured for router gateway set/unset

    Before adding support for lbs with VIPs on the provider networks,
    there was no need to react to gateway chassis creation events, and
    nothing was done for its deletion. However, after adding the support
    for that, there is a need of properly handling the creation event
    for that type of port.

    For the loadbalancer VIPs on the provider network, processing the
    event and triggering the lb_creat_lrp_assoc_handler means that the
    information about the logical router will be added, i.e., the router
    is added to the loadbalancer external_ids as a lr_ref, while the
    loadbalancer is also added into the logical_router object
    (loadbalancer entry). In addition, the lb is also added to the logical
    switches connected to the router.

    For the loadbalancer VIPs on tenant networks (which should not be
    affected by the gateway port creation/deletion), this patch ensures
    the lb is not added to the logical switch representing the provider
    network that is connected to the router. Therefore differentiating
    between lrp ports which has gateway_chassis and the ones that don't,
    i.e., adding the lb to the switch when the lrp port is the one
    connecting a subnet with the router, and not doing so when it is the
    gateway port for the router to the provider network.

    Closes-Bug: #1991509

    (manually cherry picked from commit d889812f3c2deaf630892d65c90cdbafd4435d21)

    Change-Id: Iddd96fd9015230b3dd75aa2182055cf43eb608c1
    (cherry picked from commit d889812f3c2deaf630892d65c90cdbafd4435d21)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860668
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/4fd717c92c232551e6c1549bd08d96ee88d1da6c
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 4fd717c92c232551e6c1549bd08d96ee88d1da6c
Author: Luis Tomas Bolivar <email address hidden>
Date: Fri Sep 30 20:13:49 2022 +0200

    Ensure lbs are properly configured for router gateway set/unset

    Before adding support for lbs with VIPs on the provider networks,
    there was no need to react to gateway chassis creation events, and
    nothing was done for its deletion. However, after adding the support
    for that, there is a need of properly handling the creation event
    for that type of port.

    For the loadbalancer VIPs on the provider network, processing the
    event and triggering the lb_creat_lrp_assoc_handler means that the
    information about the logical router will be added, i.e., the router
    is added to the loadbalancer external_ids as a lr_ref, while the
    loadbalancer is also added into the logical_router object
    (loadbalancer entry). In addition, the lb is also added to the logical
    switches connected to the router.

    For the loadbalancer VIPs on tenant networks (which should not be
    affected by the gateway port creation/deletion), this patch ensures
    the lb is not added to the logical switch representing the provider
    network that is connected to the router. Therefore differentiating
    between lrp ports which has gateway_chassis and the ones that don't,
    i.e., adding the lb to the switch when the lrp port is the one
    connecting a subnet with the router, and not doing so when it is the
    gateway port for the router to the provider network.

    Closes-Bug: #1991509

    Change-Id: Iddd96fd9015230b3dd75aa2182055cf43eb608c1
    (cherry picked from commit d889812f3c2deaf630892d65c90cdbafd4435d21)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860666
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/4f4c80c98e160a415d5b5129e40f0018811a68d2
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 4f4c80c98e160a415d5b5129e40f0018811a68d2
Author: Luis Tomas Bolivar <email address hidden>
Date: Fri Sep 30 20:13:49 2022 +0200

    Ensure lbs are properly configured for router gateway set/unset

    Before adding support for lbs with VIPs on the provider networks,
    there was no need to react to gateway chassis creation events, and
    nothing was done for its deletion. However, after adding the support
    for that, there is a need of properly handling the creation event
    for that type of port.

    For the loadbalancer VIPs on the provider network, processing the
    event and triggering the lb_creat_lrp_assoc_handler means that the
    information about the logical router will be added, i.e., the router
    is added to the loadbalancer external_ids as a lr_ref, while the
    loadbalancer is also added into the logical_router object
    (loadbalancer entry). In addition, the lb is also added to the logical
    switches connected to the router.

    For the loadbalancer VIPs on tenant networks (which should not be
    affected by the gateway port creation/deletion), this patch ensures
    the lb is not added to the logical switch representing the provider
    network that is connected to the router. Therefore differentiating
    between lrp ports which has gateway_chassis and the ones that don't,
    i.e., adding the lb to the switch when the lrp port is the one
    connecting a subnet with the router, and not doing so when it is the
    gateway port for the router to the provider network.

    Closes-Bug: #1991509

    Change-Id: Iddd96fd9015230b3dd75aa2182055cf43eb608c1
    (cherry picked from commit d889812f3c2deaf630892d65c90cdbafd4435d21)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 1.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn train-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 1.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 4.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 2.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 3.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider victoria-eom release.