Comment 11 for bug 876139

After some careful testing I think this looks good. Since the patch also included some other stuff from another one of your patches I committed only the powerwindow-specific things to lp:mixxx. I also see now how the toggling for single-state WPushButton's that was done previously could have easily led to button-getting-out-of-sync issues that we have seen over the years so thanks for fixing that too.

I changed your patch a little bit so that a <PowerWindow> block doesn't have to be added to buttons in the skin. Instead, it looks at the controls connected to the left and right click on WPushButton and records their button-mode in WPushButton. When clicks happen on WPushButton, it checks the left button-mode to see if powerwindow mode is enabled. I think this is cleaner since it makes sure that a skin designer can't accidentally forget to enable power-window mode for things like talkover.