The features_banshee branch reads directly from the banshee database. This is very performing on one hand but we have no guarantee from the banshee team that this will work without changes on each banshee update.
So there are objections in our team to have this in the Mixxx trunk.
I do not share these objections, because I have seen this working since I have made it without adaption to specific banshee versions.
The branch has to be ported to the baseexternal classes and I think your valid issues from the review have to be fixed an than IMO it is ready for trunk version.
The features_banshee branch reads directly from the banshee database. This is very performing on one hand but we have no guarantee from the banshee team that this will work without changes on each banshee update.
See https:/ /mail.gnome. org/archives/ banshee- list/2011- dicembre/ msg00048. html
So there are objections in our team to have this in the Mixxx trunk.
I do not share these objections, because I have seen this working since I have made it without adaption to specific banshee versions.
The branch has to be ported to the baseexternal classes and I think your valid issues from the review have to be fixed an than IMO it is ready for trunk version.
Any comments from someone else?