Comment 2 for bug 1294750

Revision history for this message
Daniel Schürmann (daschuer) wrote :

On the second thought I think this is a fix but at the wrong position.

The buttons are just an input option and should behave exactly like the slider displayed in the GUI.
In the original bug description only _up _down and _set_on is effected.
Bug #1081137

Owen's original problem was to allow out of bound values for programmatic needs, not control commands.

So the root bug was that the _up _down controls where bypassing the limit check.

Patch
https://github.com/mixxxdj/mixxx/commit/e21ffec0fe67e327b43fac81d3a55078112fa6f5
now allows to control beyond all limits for rate slider but limits all COs to be out of bound for programmatic reasons.

Possible solution:
* Remove m_bAllowOutOfBounds and check for limits in incValue() like functions. https://github.com/mixxxdj/mixxx/blob/master/src/controlpotmeter.cpp#L141 or in a common function it calls.