Allow keyboard shortcuts to work on multiple controls at once

Bug #1081137 reported by jus
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
RJ Skerry-Ryan

Bug Description

This would improve the usability of our keyboard shortcuts, we could fix some outstanding bugs with the extended functionality

Use case:
* Add keyboard shortcut for global waveform zoom, lp:1072395
* Start one deck while stopping another , lp:685733
* Start both decks at once
.....

Tags: keyboard
Revision history for this message
jus (jus) wrote :

The next use case for the feature is the Preview Deck.

Currently you have no way to easily preview tracks in the library using the keyboard. There are 2 steps involved:
"LoadSelectedTrack " to [PreviewDeck1] and "Play". Compare that with clicking on the Headphone-icon on the Preview column. It makes no sense to use two different shortcuts for start previewing a track.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

An alternative for 1.11.0 is to add a [XXX],LoadSelectedTrackAndPlay. There's also the tricky asynchronous problem we face where the 'play' needs to occur after the track has loaded. This is the same reason the preview deck sometimes doesn't play when you click the play button in the library column and we don't have a good solution to it at the moment.

Revision history for this message
jus (jus) wrote :

Additional LoadSelectedTrackAndPlay control for 1.11 sounds good.

Revision history for this message
jus (jus) wrote :

LoadSelectedTrackAndPlay control is tracked in lp:1114127

Revision history for this message
RAWRR (rawrr) wrote :

Can people developing this please tell me if this functionality might dovetail with multitouch/multicursor development? If it could, or already does, I would request please that modifications made for the cause of this bug bear a possible future feature of multitouch/multicursor in mind.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote : Re: [Bug 1081137] Re: Allow keyboard shortcuts to work on multiple controls at once

Hey RAWRR,

While they do seem similar, the underlying mechanisms aren't related.

Cheers,
RJ

On Fri, May 10, 2013 at 1:34 PM, RAWRR <email address hidden> wrote:

> Can people developing this please tell me if this functionality might
> dovetail with multitouch/multicursor development? If it could, or
> already does, I would request please that modifications made for the
> cause of this bug bear a possible future feature of
> multitouch/multicursor in mind.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1081137
>
> Title:
> Allow keyboard shortcuts to work on multiple controls at once
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1081137/+subscriptions
>

Revision history for this message
RAWRR (rawrr) wrote :

Acknowledged~

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Confirmed → Fix Committed
milestone: none → 1.12.0
assignee: nobody → RJ Ryan (rryan)
Revision history for this message
jus (jus) wrote :

Thanks for implementing this.

While testing, i noticed some unpleasant behavior and would like to make sure it does not affect other controls than waveform zoom.

I tried to solve lp:1072395 (Add keyboard shortcut for global waveform zoom)

Add following lines to /res/keyboard/en_US.kbd.cfg

// Main waveform zoom
[Channel1]
waveform_zoom_up ]
waveform_zoom_down [
waveform_zoom_set_one Shift+}
[Channel2]
waveform_zoom_up ]
waveform_zoom_down [
waveform_zoom_set_one Shift+}
[Channel3]
waveform_zoom_up ]
waveform_zoom_down [
waveform_zoom_set_one Shift+}
[Channel4]
waveform_zoom_up ]
waveform_zoom_down [
waveform_zoom_set_one Shift+}

This seems to work ok, but try to press multiple times extra once you reached the maximum zoom in. Then press zoom out and notices how it does nothing at first, just keep pressing the button. This gets even weirder, if you have wavezoom sync disabled in the preferences (default), and have one or more waveforms zoomed at different rates.

Looks like the counter is silently incremented, and is not limited to the range (1-6 in case of the waveform zoom). Sidenote: We should set the waveform sync option to ON by default.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Ah, this was caused in db2f130cb32f5484ca064b83d211cb3afeeb595e. Owen removed the range limiting on ControlPotmeters.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Now fixed: Bug #1294750

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6708

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.