Comment 11 for bug 1160353

Found it -- Bug #517373. This was because our warning handler would show a
message box on qWarning which would sometimes happen when a paint event was
already active. So that's not really related to what's going on here.

I agree we should fix that deadlock but like you said it won't actually fix
this bug because we were already in the qCritical handler which would have
aborted us. Is a shader link failure really a quit-worthy event? Is that
just because Qt qCritical's it? Maybe we should stop quitting Mixxx on
qCritical and just explicitly quit everywhere Mixxx has a qCritical that is
quit-worthy.

On Thu, Apr 4, 2013 at 10:25 AM, RJ Ryan <email address hidden> wrote:

> Nice work! We've had an issue like this before related to the waveforms in
> a much older version of Mixxx. I can't seem to find the bug report though.
>
>
> On Thu, Apr 4, 2013 at 9:01 AM, Daniel Schürmann <
> <email address hidden>> wrote:
>
>> Ok, I think I have narrowed it down.
>>
>> The deadlock is, is caused by Mixxx itself, because it tries to display
>> the "Critical Error" Message Box from the Shinny Paint event.
>> This causes a a new Spinny paint event. A paint event within a paint
>> event seams to lead to a deadlock.
>>
>> We exit Mixxx in any case on after closing the critical error message so
>> the deadlock problem is a minor one.
>> An without the deadlock we where not able to get such a significant
>> backtrace :-).
>>
>> So I will try Max's idea to check
>> http://qt-project.org/doc/qt-4.8/qglwidget.html#isValid before painting.
>>
>>
>>
>> ** Changed in: mixxx
>> Assignee: (unassigned) => Daniel Schürmann (daschuer)
>>
>> ** Changed in: mixxx
>> Status: New => In Progress
>>
>> ** Changed in: mixxx
>> Importance: Undecided => High
>>
>> --
>> You received this bug notification because you are a member of Mixxx
>> Development Team, which is subscribed to Mixxx.
>> https://bugs.launchpad.net/bugs/1160353
>>
>> Title:
>> "critical error" on startup with software gl renderer
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/mixxx/+bug/1160353/+subscriptions
>>
>
>