Comment 6 for bug 1074346

Revision history for this message
xorik (xor29a) wrote :

OK, When I change hue of color, depending of low and high freq. value I got this: http://ompldr.org/vZzQ5cw
Just make this:
- lo = maxLow[0]/300.0;
+ lo = maxLow[0]/200.0;

- color.setHsvF(h, 1.0-hi, 1.0-lo);
+ color.setHsvF(h+(lo-hi)/3.0, s, v);

I think this if worse, than my first screenshot.

About perfomance: my code is use 60% of my CPU when mixxx, but "filtered - software" uses just 40% cpu. Maybe someon can make some optimizations, but I can't...

P.S. I forgot to add one file to my patch, there is:
--- a/mixxx/build/depends.py
+++ b/mixxx/build/depends.py
@@ -633,6 +633,7 @@ class MixxxCore(Feature):
                    "waveform/renderers/waveformrendererpreroll.cpp",

                    "waveform/renderers/waveformrendererfilteredsignal.cpp",
+ "waveform/renderers/waveformrendererhsv.cpp",
                    "waveform/renderers/qtwaveformrendererfilteredsignal.cpp",
                    "waveform/renderers/qtwaveformrenderersimplesignal.cpp",
                    "waveform/renderers/glwaveformrendererfilteredsignal.cpp",
@@ -649,6 +650,7 @@ class MixxxCore(Feature):
                    "waveform/widgets/waveformwidgetabstract.cpp",
                    "waveform/widgets/emptywaveformwidget.cpp",
                    "waveform/widgets/softwarewaveformwidget.cpp",
+ "waveform/widgets/hsvwaveformwidget.cpp",
                    "waveform/widgets/qtwaveformwidget.cpp",
                    "waveform/widgets/qtsimplewaveformwidget.cpp",
                    "waveform/widgets/glwaveformwidget.cpp",