New cool waveform renderer (HSV)

[xorik]

Hi!
I make patches, to add to mixxx new waveform renderer, based on software filtered renderer.
I never before write on Qt, so my code may be terrible. But anyway new renderer is cool, you can see it on screenshot: http://ompldr.org/vZ216bA
to apply patch, just go to mixxx directory and run "patch -p1 < hsv.patch".

That is not good:
- 90% of code is copy+pasted from filtered waveform, so there is many dublicated functions;
- CPU usage is pretty big (depends on waveform refresh framerate). In fact this problem is present in another waveform renderers;
- in filtered signal there was code, something like: Qt::AlignBottom and Qt::AlignTop. I killed this code

[jus (jus)]

Nice, and very useful imo.
It`s like http://flic.kr/p/absqfa from lp:823354, which did not made it into trunk for whatever reasons.

[Sean M. Pappalardo (pegasus-renegadetech)]

Wow, nice, Xorik!
Can you make it change the hue rather than the lightness? To me it's easier to see colors than luminance at a glance.

[xorik (xor29a)]

I can try to do this, but I think it was hard to determine sound's frequency, depending on color, if you see rainbow waveform :)
Or maybe you mean draw both waveforms in same colors? like: high->yellow, mid->green, low->blue?

[Daniel Schürmann (daschuer)]

Thank you xorik.
This schould be a good alternative vor low performance hadware because we have only one drawLine() per visual sample it should be significant faster..
I would vote vor having it in 1.11.
Maybe we can also prepare a pure GL version.
(I am making good progress in dejerking GL waveforms , but not with Software rendered)

[xorik (xor29a)]

OK, When I change hue of color, depending of low and high freq. value I got this: http://ompldr.org/vZzQ5cw
Just make this:
- lo = maxLow[0]/300.0;
+ lo = maxLow[0]/200.0;

- color.setHsvF(h, 1.0-hi, 1.0-lo);
+ color.setHsvF(h+(lo-hi)/3.0, s, v);

I think this if worse, than my first screenshot.

About perfomance: my code is use 60% of my CPU when mixxx, but "filtered - software" uses just 40% cpu. Maybe someon can make some optimizations, but I can't...

P.S. I forgot to add one file to my patch, there is:
--- a/mixxx/build/depends.py
+++ b/mixxx/build/depends.py
@@ -633,6 +633,7 @@ class MixxxCore(Feature):
                    "waveform/renderers/waveformrendererpreroll.cpp",

                    "waveform/renderers/waveformrendererfilteredsignal.cpp",
+ "waveform/renderers/waveformrendererhsv.cpp",
                    "waveform/renderers/qtwaveformrendererfilteredsignal.cpp",
                    "waveform/renderers/qtwaveformrenderersimplesignal.cpp",
                    "waveform/renderers/glwaveformrendererfilteredsignal.cpp",
@@ -649,6 +650,7 @@ class MixxxCore(Feature):
                    "waveform/widgets/waveformwidgetabstract.cpp",
                    "waveform/widgets/emptywaveformwidget.cpp",
                    "waveform/widgets/softwarewaveformwidget.cpp",
+ "waveform/widgets/hsvwaveformwidget.cpp",
                    "waveform/widgets/qtwaveformwidget.cpp",
                    "waveform/widgets/qtsimplewaveformwidget.cpp",
                    "waveform/widgets/glwaveformwidget.cpp",

[xorik (xor29a)]

use 60% of my CPU when mixxx idle, I mean

[Daniel Schürmann (daschuer)]

a little hint: please create the patch by
bzr diff > patchname.patch

[Sean M. Pappalardo (pegasus-renegadetech)]

Hrm, I see what you meant by rainbow waveforms. I wonder if we can use the skin colors but tint them like a little red for bass and blue for treble. I'll play around with your patch and see what I can cook up. Thanks so much for submitting it!

[xorik (xor29a)]

You can do anything with my patch :)
Also If you plan include it into mixxx, maybe you want to rename this waveform render. Also maybe someone can improve CPU usage...

[xorik (xor29a)]

Synced with upstream, fix bug #1065318

[Sean M. Pappalardo (pegasus-renegadetech)]

Oh, would you please sign the contributor agreement here? https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ
And let us know your real name to put in the credits.

[xorik (xor29a)]

done, my name is Andrey Smelov

[xorik (xor29a)]

Hi all!
I check my code, and was notified: all my math is not correct. So I rewrite math code, and now waveform is more correct and nice: http://ompldr.org/vZ216bA

[xorik (xor29a)]

Latest version of hsv.patch

[RJ Skerry-Ryan (rryan)]

Hi Xorik,

Can you work on adding AlignBottom/AlignTop support? It is a feature of the
waveform that the signal can be drawn aligned top or bottom and we will
likely use this in a future skin so it's important all the waveform
renderers support it.

Thanks!
RJ

On Mon, Dec 10, 2012 at 2:41 AM, xorik <email address hidden> wrote:

> ** Description changed:
>
> Hi!
> I make patches, to add to mixxx new waveform renderer, based on software
> filtered renderer.
> - I never before write on Qt, so my code may be terrible. But anyway new
> renderer is cool, you can see it on screenshot: http://ompldr.org/vZzQ4Yg
> + I never before write on Qt, so my code may be terrible. But anyway new
> renderer is cool, you can see it on screenshot: http://ompldr.org/vZ216bA
> to apply patch, just go to mixxx directory and run "patch -p1 <
> hsv.patch".
> +
> + That is not good:
> + - 90% of code is copy+pasted from filtered waveform, so there is many
> dublicated functions;
> + - CPU usage is pretty big (depends on waveform refresh framerate). In
> fact this problem is present in another waveform renderers;
> + - in filtered signal there was code, something like: Qt::AlignBottom and
> Qt::AlignTop. I killed this code
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1074346
>
> Title:
> New cool waveform renderer (HSV)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1074346/+subscriptions
>

[xorik (xor29a)]

Ok, I'll try it, but I'm not sure, how to debug it :)

[xorik (xor29a)]

Yet another version of patch.
- AlignBottom/AlignTop support
- fixed wrong visual waveform on some cases

[xorik (xor29a)]

Oops, I mean visual gain, not waveform

[Daniel Schürmann (daschuer)]

Hi xorik,

Thank you very much!
I have committed your patch to lp:mixxx/1.11 #3624 and will add you to the contributor list.

Kind regards
Daniel

[xorik (xor29a)]

I'm glad to help :)

[Robert Broadley (rob2192)]

Would it be possible to change colour of the waveform dependant on key. I'm pretty sure there is a vamp plugin that can detect the key changes in music. I think it's the key detector on here - http://www.vamp-plugins.org/plugin-doc/qm-vamp-plugins.html#qm-tonalchange.

This could be really useful for detecting melodic changes and also finding where in the tracks to mix - i.e. sam colour should mixxx harmonically.

Thanks for the great work
Rob

[Daniel Schürmann (daschuer)]

Thank you for your post.

Can you please file a new bug, because this is already committed.
So we can better keep track of it.
It sounds similar to Bug #1074392 what do you think?

[Robert Broadley (rob2192)]

Added new bug report here https://bugs.launchpad.net/mixxx/+bug/1099782
I think this could be potentially much more useful than the moodbar depending how you mix as it would be simpler to interpret.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6684