Comment 18 for bug 1074346

Hi Xorik,

Can you work on adding AlignBottom/AlignTop support? It is a feature of the
waveform that the signal can be drawn aligned top or bottom and we will
likely use this in a future skin so it's important all the waveform
renderers support it.

Thanks!
RJ

On Mon, Dec 10, 2012 at 2:41 AM, xorik <email address hidden> wrote:

> ** Description changed:
>
> Hi!
> I make patches, to add to mixxx new waveform renderer, based on software
> filtered renderer.
> - I never before write on Qt, so my code may be terrible. But anyway new
> renderer is cool, you can see it on screenshot: http://ompldr.org/vZzQ4Yg
> + I never before write on Qt, so my code may be terrible. But anyway new
> renderer is cool, you can see it on screenshot: http://ompldr.org/vZ216bA
> to apply patch, just go to mixxx directory and run "patch -p1 <
> hsv.patch".
> +
> + That is not good:
> + - 90% of code is copy+pasted from filtered waveform, so there is many
> dublicated functions;
> + - CPU usage is pretty big (depends on waveform refresh framerate). In
> fact this problem is present in another waveform renderers;
> + - in filtered signal there was code, something like: Qt::AlignBottom and
> Qt::AlignTop. I killed this code
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1074346
>
> Title:
> New cool waveform renderer (HSV)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1074346/+subscriptions
>