Comment 2 for bug 1035438

Revision history for this message
RJ Skerry-Ryan (rryan) wrote : Re: [Bug 1035438] Re: no respons to gain rotary in the second halve

The ControlLogpotmeter for pregain maxes out at 4. while we max() the
effective total gain at 2. This max was added to prevent insane gains from
being applied to due to script errors (NaN, etc.) or bad replaygain
detection.

Sean : this isn't really related to replaygain in that way -- it wouldn't
matter if the replaygain was visible on-screen or not.

Since the choice of 2.0 for max was arbitrary, I would just extend that to
something larger. It was meant to prevent gigantic gains (e.g. >100).

On Fri, Aug 10, 2012 at 4:31 PM, Sean M. Pappalardo <
<email address hidden>> wrote:

> For the record, stuff like this is why I was lobbying to have the
> ReplayGain system change the on-screen pregain knob instead of a hidden
> one.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1035438
>
> Title:
> no respons to gain rotary in the second half
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1035438/+subscriptions
>