no respons to gain rotary in the second half

[Daniel Schürmann]

This is due to the limit of total gain of 2.

If you now have a calculated replay gain of > 1, the according part of the gain rotary is dead.

I propose to limit the replay gain to 2 and have always the gain rotary responsive over the whole scale .

[Sean M. Pappalardo (pegasus-renegadetech)]

For the record, stuff like this is why I was lobbying to have the ReplayGain system change the on-screen pregain knob instead of a hidden one.

[RJ Skerry-Ryan (rryan)]

The ControlLogpotmeter for pregain maxes out at 4. while we max() the
effective total gain at 2. This max was added to prevent insane gains from
being applied to due to script errors (NaN, etc.) or bad replaygain
detection.

Sean : this isn't really related to replaygain in that way -- it wouldn't
matter if the replaygain was visible on-screen or not.

Since the choice of 2.0 for max was arbitrary, I would just extend that to
something larger. It was meant to prevent gigantic gains (e.g. >100).

On Fri, Aug 10, 2012 at 4:31 PM, Sean M. Pappalardo <
<email address hidden>> wrote:

> For the record, stuff like this is why I was lobbying to have the
> ReplayGain system change the on-screen pregain knob instead of a hidden
> one.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1035438
>
> Title:
> no respons to gain rotary in the second half
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1035438/+subscriptions
>

[Daniel Schürmann (daschuer)]

The attached patch does not limit the value of the gain rotary any more.
The replay gain is now limited to 10 to allow the whole scale of the replay gain boost and a calculated replay gain up to ~2.

[RJ Skerry-Ryan (rryan)]

Looks good to me.. thanks Daniel.

On Fri, Aug 10, 2012 at 6:43 PM, Daniel Schürmann <
<email address hidden>> wrote:

> The attached patch does not limit the value of the gain rotary any more.
> The replay gain is now limited to 10 to allow the whole scale of the
> replay gain boost and a calculated replay gain up to ~2.
>
> ** Patch added: "gainlimit.patch"
>
> https://bugs.launchpad.net/mixxx/+bug/1035438/+attachment/3256308/+files/gainlimit.patch
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1035438
>
> Title:
> no respons to gain rotary in the second half
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1035438/+subscriptions
>

[Daniel Schürmann (daschuer)]

Committed to lp:mixxx/1.11 #3341

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6607