[regression] mir_demo_client_multiwin is displayed with obviously wrong colours
Bug #1339471 reported by
Daniel van Vugt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Daniel van Vugt | ||
mir (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
I just noticed client-provided alpha is not being blended correctly and mir_demo_
Test case: Run mir_demo_
Expected: The pure red/green/blue regions should be darkened by their high transparency and the grey background behind them.
Observed: The pure red/green/blue regions are full brightness, despite having opacity of only 0x50 (0.31f) in front of a grey background.
Related branches
lp:~vanvugt/mir/fix-1339471
- Alberto Aguirre (community): Disapprove
- Alexandros Frantzis (community): Disapprove
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 187 lines (+29/-41)6 files modifiedexamples/demo-shell/demo_renderer.cpp (+11/-11)
examples/eglcounter.cpp (+2/-3)
examples/eglflash.c (+11/-21)
examples/egltriangle.c (+2/-3)
src/server/compositor/gl_renderer.cpp (+2/-2)
tests/unit-tests/compositor/test_gl_renderer.cpp (+1/-1)
lp:~vanvugt/mir/fix-1339471-demoonly
- Alexandros Frantzis (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 41 lines (+10/-0)1 file modifiedexamples/multiwin.c (+10/-0)
Changed in mir: | |
assignee: | nobody → Daniel van Vugt (vanvugt) |
status: | Triaged → In Progress |
Changed in mir (Ubuntu): | |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Bisected. The bug was introduced here:
------- ------- ------- ------- ------- ------- ------- ------- ---- /bugs.launchpad .net/bugs/ 1318852.
revno: 1687 [merge]
author: Alberto Aguirre <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Fri 2014-06-06 16:03:10 +0000
message:
renderer: Generate correct alpha by changing blending equation to assume pre-multiplied alpha sources(LP: #1318852). Fixes: https:/
Approved by Alexandros Frantzis, Andreas Pokorny, PS Jenkins bot. ------- ------- ------- ------- ------- ------- ------- ----
-------