nexus 10 leaks resources during overlay operations
Bug #1331769 reported by
Kevin DuBois
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
High
|
Kevin DuBois | ||
mir (Ubuntu) |
Fix Released
|
High
|
Unassigned |
Bug Description
If you run the server with overlays enabled, after a while you'll see:
W/hwcomposer(
E/hwcomposer(
F/hwcomposer(
which probably means we're leaking fences around the hwc set when overlays are enabled. This doesn't seem to effect the other classes of devices. It shouldn't affect the unity stack, as the overlay optimization is currently disabled.
Related branches
lp:~kdub/mir/fix-1331769
- PS Jenkins bot (community): Approve (continuous-integration)
- Robert Carr (community): Approve
- Alan Griffiths: Needs Fixing
- Alexandros Frantzis (community): Approve
-
Diff: 193 lines (+63/-22)3 files modifiedsrc/platform/graphics/android/hwc_device.cpp (+9/-5)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+54/-15)
tests/unit-tests/graphics/android/test_hwc_layers.cpp (+0/-2)
Changed in mir: | |
milestone: | none → 0.4.0 |
Changed in mir: | |
milestone: | 0.4.0 → 0.5.0 |
Changed in mir (Ubuntu): | |
importance: | Undecided → High |
status: | New → Triaged |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
What seems to be happening is when the nexus10 hwc accepts all the layers as overlays, it refuses to accept ownership of the hwc_layer_ 1_t::acquireFen ceFd on the HWC_FRAMEBUFFER _TARGET layer. The other types of devices seem to close this fd, but on this device, the fence leaks, eventually depleting the pool of fences the kernel can give us.