The clear button must be handled separately. That code will do nothing if you build with GTK+ 3.2. I would suggest something like sokoke_entry_add_clear_button, it could be used in all other places as well. It could also be something like _set_placeholder_text_with_button if that is generic enough, no strong opinion there.
If you don't mind I would like you to keep the "else" part in midori_search_action_icon_released_cb as it is and rather put a return there. It takes quite a bit more effort to realize that the code was merely re-indented and not changed.
The clear button must be handled separately. That code will do nothing if you build with GTK+ 3.2. I would suggest something like sokoke_ entry_add_ clear_button, it could be used in all other places as well. It could also be something like _set_placeholde r_text_ with_button if that is generic enough, no strong opinion there.
If you don't mind I would like you to keep the "else" part in midori_ search_ action_ icon_released_ cb as it is and rather put a return there. It takes quite a bit more effort to realize that the code was merely re-indented and not changed.