Show clear button if there is text to be cleared

[Danielle Foré]

If there exists text in the Searchbar, the clear icon should be shown in order to more easily clear up the field.

[i (iiiiii-deactivatedaccount)]

Hitting ctrl+k will select the whole field. You can then either delete the text or type something else.

[Danielle Foré (danrabbit)]

random keyboard shortcuts aren't really good for most users.

[i (iiiiii-deactivatedaccount)]

Ok, you think there should be a 'Clear' button in the searchbar. Someone else might think that is clutter.

ctrl+k is not random. It's the search bar shortcut for mozilla browsers for ages and (thus) is the shortcut for 'search' in Chrome/Chromium too.

[Danielle Foré (danrabbit)]

I don't *think* there should be a clear icon, it's dictated by elementary HIG (which is currently unavailable since the site is under constrcution).

But once again, keyboard shortcuts aren't really a good solution for most users. And in the case of tablets and the like keyboard shortcuts are impossible.

[Cris Dywan (kalikiana)]

The clear button must be handled separately. That code will do nothing if you build with GTK+ 3.2. I would suggest something like sokoke_entry_add_clear_button, it could be used in all other places as well. It could also be something like _set_placeholder_text_with_button if that is generic enough, no strong opinion there.

If you don't mind I would like you to keep the "else" part in midori_search_action_icon_released_cb as it is and rather put a return there. It takes quite a bit more effort to realize that the code was merely re-indented and not changed.

[Cris Dywan (kalikiana)]

Before committing the code, I moved it to sokoke.c. You can't put code in 'katze' that depends on gtkiconentry which lives in 'midori', only the other way around. There was also a g_emit_signal_by_name which I removed - you can't rely on behavior in the fallback code that is different to upstream. If you observe a bug without that call, please file it separately and we can think of a compatible solution.