Comment 2 for bug 1006629

HI

I've investigated around kaikiana's patch.

The theming and hovering issues seem to be due to the specific behaviour of GtkToolItem and I believe there is another one:
* the item never gets the "drag-data-get" signal.

I achieve basic DND operations if the gtk_drag_source_set is done to the "child" of the toolitem.

At the moment my prototype does it the same way the signal "button-press-event" is installed on bookmarkbar's items, in the function "bookmarkbar_insert_item", but I suspect this results from a potential deficiency in the function "katze_array_action_create_tool_item_for".

I wonder if, the same way it does it for the label update, the "katze_array_action_create_tool_item_for" should not connect to the toolitem's child's signals "button-press-event", "drag-data-get" and "drag-data-delete".

The change for the "button-press-event" would allow us to get rid of the 'duplicates' I see between the functions "midori_bookmarkbar_activate_item_alt" and "midori_bookmarkbar_item_button_press_event_cb".

And if I jump one step ahead probably let us unify bookmark context menus and dnd sourcing for toolbar, drop-down menu and treeview.

What do you think?