Rearrange Bookmarks Toolbar with Drag and Drop

[Pierre Bender]

It is impossible to move a bookmark to another place in the bookmarkbar. If I try to drag a bookmark, nothing happens. It would be very nice to develope such feature. :-)

[Cris Dywan (kalikiana)]

This patch is a starting point, bookmark bar items can be dragged. For some reason themeing breaks and hovering with the mouse no longer shows anything with the patch.
Any takes welcome to further research in this area.

[André Auzi (aauzi)]

HI

I've investigated around kaikiana's patch.

The theming and hovering issues seem to be due to the specific behaviour of GtkToolItem and I believe there is another one:
* the item never gets the "drag-data-get" signal.

I achieve basic DND operations if the gtk_drag_source_set is done to the "child" of the toolitem.

At the moment my prototype does it the same way the signal "button-press-event" is installed on bookmarkbar's items, in the function "bookmarkbar_insert_item", but I suspect this results from a potential deficiency in the function "katze_array_action_create_tool_item_for".

I wonder if, the same way it does it for the label update, the "katze_array_action_create_tool_item_for" should not connect to the toolitem's child's signals "button-press-event", "drag-data-get" and "drag-data-delete".

The change for the "button-press-event" would allow us to get rid of the 'duplicates' I see between the functions "midori_bookmarkbar_activate_item_alt" and "midori_bookmarkbar_item_button_press_event_cb".

And if I jump one step ahead probably let us unify bookmark context menus and dnd sourcing for toolbar, drop-down menu and treeview.

What do you think?

[André Auzi (aauzi)]

The prototype in lp:~aauzi/midori/fix-1006629, implements bookmark bar and menus DND in the bookmark bar.
I'm still looking for an idea for a drop destination that would remove the bookmark from the bookmark bar.

[982c80311320c1b (alexander-wilms)]

When dragging an item, a trashcan icon could be shown on one side of of the tool bar. But OTOH, I never missed the option to delete an item by dragging in other browsers. Is this why the branch hasn't already been proposed for merging?