Comment 0 for bug 1929421

Description
===========
The ONTAP has different default space guarantee value for the AFF and FAS platforms. The AFF uses the thin provsioning and the FAS the thick provisioning [1].

Create a share with extra-specs `thin_provisioning` as False (or without setting it) should end up with the volume as thick provisoning. In a AFF system (or select premium with SSD) it will be thin one, though.

The error comes the fact that the NetApp driver is not setting the thick provisioning when the extra-specs is False, it does not set anything, leaving as the storage default [2].

The possible solution could be set as:

api_args['space-reserve'] = 'none' if thin_provisioning else 'volume'

[1] https://docs.netapp.com/ontap-9/index.jsp?topic=%2Fcom.netapp.doc.dot-cm-vsmg%2FGUID-14D3192C-C4AB-4003-9FC2-290F23754904.html
[2] https://github.com/openstack/manila/blob/a3aaea91494665a25bdccebf69d9e85e8475983d/manila/share/drivers/netapp/dataontap/client/client_cmode.py#L2030

Steps to reproduce
==================

A AFF ONTAP cluster.

1) Create a share using a share type with extra-spces `thin_provisioning=False`

2) Go to ONTAP and see the field `space-guarantee` of the created share

Expected result
===============

The field should be `volume` (thick).

Actual result
=============

The field is set as `none` (thin).

Environment
===========
1. Manila version: Latest 12.1.0

2. NetApp ONTAP 9.8

Logs & Configs
==============