OpenStack Shared File Systems Service (Manila)

NetApp driver cannot configure thick provisioning with AFF platforms

Bug #1929421 reported by Felipe Rodrigues on 2021-05-24

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Shared File Systems Service (Manila)	Fix Released	Medium	Nahim Alves de Souza	OpenStack Shared File Systems Service (Manila) yoga-2

Bug Description

Description
===========
The ONTAP has different default space guarantee value for the AFF and FAS platforms. The AFF uses the thin provsioning and the FAS the thick provisioning [1].

Create a share with extra-specs `thin_provisioning` as False (or without setting it) should end up with the volume as thick provisoning. In a AFF system (or select premium with SSD) it will be thin one, though.

The error comes from the fact that the NetApp driver is not setting the thick provisioning when the extra-specs is False, it does not set anything, leaving as the storage default [2].

The possible solution could be set as:

api_args['space-reserve'] = 'none' if thin_provisioning else 'volume'

[1] https://docs.netapp.com/ontap-9/index.jsp?topic=%2Fcom.netapp.doc.dot-cm-vsmg%2FGUID-14D3192C-C4AB-4003-9FC2-290F23754904.html
[2] https://github.com/openstack/manila/blob/a3aaea91494665a25bdccebf69d9e85e8475983d/manila/share/drivers/netapp/dataontap/client/client_cmode.py#L2030

Steps to reproduce
==================

A AFF ONTAP cluster.

1) Create a share using a share type with extra-spces `thin_provisioning=False`

2) Go to ONTAP and see the field `space-guarantee` of the created share

Expected result
===============

The field should be `volume` (thick).

Actual result
=============

The field is set as `none` (thin).

Environment
===========
1. Manila version: Latest 12.1.0

2. NetApp ONTAP 9.8

Logs & Configs
==============

See original description

Tags:

Felipe Rodrigues (felipefutty) on 2021-05-24

description:

updated

Vida Haririan (vhariria) on 2021-05-26

tags:

added: netapp

Carlos Eduardo (silvacarlose) on 2021-05-31

Changed in manila:
assignee:	nobody → Nahim Alves de Souza (nahimsouza)

Carlos Eduardo (silvacarlose) on 2021-06-03

Changed in manila:
milestone:	none → xena-2
importance:	Undecided → Medium
status:	New → Confirmed

Revision history for this message

Goutham Pacha Ravi (gouthamr) wrote on 2021-09-10:

Nahim, we're closing on xena-RC1 soon.

i'm moving this bug to Yoga-1; please let me know if that timeline is inaccurate.

Changed in manila:
milestone:	xena-2 → yoga-1

Revision history for this message

Nahim Alves de Souza (nahimsouza) wrote on 2021-09-10:

It's ok for me Goutham. Thanks.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-09-28: Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/811417

Changed in manila:
status:	Confirmed → In Progress

Goutham Pacha Ravi (gouthamr) on 2021-11-29

Changed in manila:
milestone:	yoga-1 → yoga-2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-12-08: Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/811417
Committed: https://opendev.org/openstack/manila/commit/c1db551775c512e42001a8183975f1abbc4c5253
Submitter: "Zuul (22348)"
Branch: master

commit c1db551775c512e42001a8183975f1abbc4c5253
Author: Nahim Alves de Souza <email address hidden>
Date: Fri Jun 4 21:12:48 2021 +0000

[NetApp] Fix default thin_provisioned volumes on AFF

    The NetApp ONTAP driver was creating thin provisioned volumes on
    AFF systems even when the thin provisioned extra spec was saying
    the contrary.

    ONTAP AFF systems create thin provisioned volumes by default, which
    differs from FAS systems, that creates thick provisioned volumes by
    default.

The NetApp ONTAP driver was modified to fix this misbehavior.

Change-Id: I9218bf0d7cb607dd75e892ce86af958d43a7fcdb
Closes-Bug: #1929421

Changed in manila:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-02-11: Fix proposed to manila (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/manila/+/828760

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-02-11: Fix proposed to manila (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/manila/+/828811

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-02-11: Fix proposed to manila (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/manila/+/828761

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-02-11: Fix proposed to manila (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/manila/+/828762

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-02-11: Fix proposed to manila (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/manila/+/828763

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-02-23: Fix merged to manila (stable/xena)

#10

Reviewed: https://review.opendev.org/c/openstack/manila/+/828760
Committed: https://opendev.org/openstack/manila/commit/eb813e0800d5204cdb3ce9ec997c799c06f13ab1
Submitter: "Zuul (22348)"
Branch: stable/xena

commit eb813e0800d5204cdb3ce9ec997c799c06f13ab1
Author: Nahim Alves de Souza <email address hidden>
Date: Fri Jun 4 21:12:48 2021 +0000

[NetApp] Fix default thin_provisioned volumes on AFF

    The NetApp ONTAP driver was creating thin provisioned volumes on
    AFF systems even when the thin provisioned extra spec was saying
    the contrary.

    ONTAP AFF systems create thin provisioned volumes by default, which
    differs from FAS systems, that creates thick provisioned volumes by
    default.

The NetApp ONTAP driver was modified to fix this misbehavior.

    Change-Id: I9218bf0d7cb607dd75e892ce86af958d43a7fcdb
    Closes-Bug: #1929421
    (cherry picked from commit c1db551775c512e42001a8183975f1abbc4c5253)

tags:

added: in-stable-xena

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-03-11: Fix included in openstack/manila 14.0.0.0rc1

#11

This issue was fixed in the openstack/manila 14.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-04-01: Fix merged to manila (stable/wallaby)

#12

Reviewed: https://review.opendev.org/c/openstack/manila/+/828811
Committed: https://opendev.org/openstack/manila/commit/596f01905dfcf9188f7e0d4400e73ce8fbf036bf
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 596f01905dfcf9188f7e0d4400e73ce8fbf036bf
Author: Nahim Alves de Souza <email address hidden>
Date: Fri Jun 4 21:12:48 2021 +0000

[NetApp] Fix default thin_provisioned volumes on AFF

    The NetApp ONTAP driver was creating thin provisioned volumes on
    AFF systems even when the thin provisioned extra spec was saying
    the contrary.

    ONTAP AFF systems create thin provisioned volumes by default, which
    differs from FAS systems, that creates thick provisioned volumes by
    default.

The NetApp ONTAP driver was modified to fix this misbehavior.

tags:

added: in-stable-wallaby

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-04-01: Fix merged to manila (stable/victoria)

#13

Reviewed: https://review.opendev.org/c/openstack/manila/+/828761
Committed: https://opendev.org/openstack/manila/commit/a695aac60d2352d55f5a9afcb81dbaadb0f26d3e
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit a695aac60d2352d55f5a9afcb81dbaadb0f26d3e
Author: Nahim Alves de Souza <email address hidden>
Date: Fri Jun 4 21:12:48 2021 +0000

[NetApp] Fix default thin_provisioned volumes on AFF

    The NetApp ONTAP driver was creating thin provisioned volumes on
    AFF systems even when the thin provisioned extra spec was saying
    the contrary.

    ONTAP AFF systems create thin provisioned volumes by default, which
    differs from FAS systems, that creates thick provisioned volumes by
    default.

The NetApp ONTAP driver was modified to fix this misbehavior.

tags:

added: in-stable-victoria

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-04-05: Fix merged to manila (stable/ussuri)

#14

Reviewed: https://review.opendev.org/c/openstack/manila/+/828762
Committed: https://opendev.org/openstack/manila/commit/ddb34f8c0dde097b69ef661d30fb1ee1dad37238
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit ddb34f8c0dde097b69ef661d30fb1ee1dad37238
Author: Nahim Alves de Souza <email address hidden>
Date: Fri Jun 4 21:12:48 2021 +0000

[NetApp] Fix default thin_provisioned volumes on AFF

    The NetApp ONTAP driver was creating thin provisioned volumes on
    AFF systems even when the thin provisioned extra spec was saying
    the contrary.

    ONTAP AFF systems create thin provisioned volumes by default, which
    differs from FAS systems, that creates thick provisioned volumes by
    default.

The NetApp ONTAP driver was modified to fix this misbehavior.

    Change-Id: I9218bf0d7cb607dd75e892ce86af958d43a7fcdb
    Closes-Bug: #1929421
    (cherry picked from commit c1db551775c512e42001a8183975f1abbc4c5253)
    (cherry picked from commit eb813e0800d5204cdb3ce9ec997c799c06f13ab1)
    (cherry picked from commit 596f01905dfcf9188f7e0d4400e73ce8fbf036bf)
    (cherry picked from commit a695aac60d2352d55f5a9afcb81dbaadb0f26d3e)

tags:

added: in-stable-ussuri

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-04-05: Fix merged to manila (stable/train)

#15

Reviewed: https://review.opendev.org/c/openstack/manila/+/828763
Committed: https://opendev.org/openstack/manila/commit/a5f8d445ea434eadbafc02a89e959765f1bdebfd
Submitter: "Zuul (22348)"
Branch: stable/train

commit a5f8d445ea434eadbafc02a89e959765f1bdebfd
Author: Nahim Alves de Souza <email address hidden>
Date: Fri Jun 4 21:12:48 2021 +0000

[NetApp] Fix default thin_provisioned volumes on AFF

    The NetApp ONTAP driver was creating thin provisioned volumes on
    AFF systems even when the thin provisioned extra spec was saying
    the contrary.

    ONTAP AFF systems create thin provisioned volumes by default, which
    differs from FAS systems, that creates thick provisioned volumes by
    default.

The NetApp ONTAP driver was modified to fix this misbehavior.