Group - View group string not translate

Bug #1818279 reported by Aurelien Besson on 2019-03-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Lisa Seeto

Bug Description

Hi,

In group views, i have a title 'Group homepage' stay in english but i'am in French.

I can't find where is string is transalte or used.

See picture in comment.

Thank you

Aurelien Besson (abesson) wrote :

See file

description: updated

The string "grouphomepageviewtitle" found in lang/en.utf8/view.php is not used for the title translation by the looks of it. Like other Mahara pages, once the page is created, it retains its title. Since you can't actually change the title "Group homepage" it would be good to always use the translated generic title.

This should be done similarly to how we deal with the profile and dashboard pages.

Changed in mahara:
status: New → Invalid
status: Invalid → Confirmed
importance: Undecided → Medium
tags: added: bite-sized
Lisa Seeto (lisaseeto) on 2019-03-25
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Lisa Seeto (lisaseeto)
Lisa Seeto (lisaseeto) wrote :

It seems that the template file "groupviewssection.tpl was displaying the group's title instead of the group's display title which was the translated string.

Reviewed: https://reviews.mahara.org/9662
Committed: https://git.mahara.org/mahara/mahara/commit/343cb133142fd8115e0b78f09c4fe100a54298ea
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 343cb133142fd8115e0b78f09c4fe100a54298ea
Author: Lisa Seeto <email address hidden>
Date: Tue Mar 26 14:32:22 2019 +1300

Bug 1818279: Group - View group string not translate

updated groupviewssection.tpl to use view.displaytitle instead
of title to pick up translated string

behatnotneeded

Change-Id: Iec3afce4fbcadc83e91e966390af05c4526df1af
Signed-off-by: Lisa Seeto <email address hidden>

Robert Lyon (robertl-9) on 2019-03-27
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
milestone: none → 19.04.0
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments