Can't choose which comment to make public

Bug #1729423 reported by David Truong on 2017-11-01
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Cecilia Vela Gurovic
17.04
High
Unassigned
17.10
High
Unassigned
18.04
High
Cecilia Vela Gurovic

Bug Description

I'm on 17.04.4

There is multiple private comments on the same item(page or collections).

Whenever i click on "make comment public" other than the first one, the first comment available on the page to be made public is made public or a request is sent if you're not allowed to. The "make comment public" appearing on each comment doesn't refer to the comment it is attached to but to the first comment with the link.

David Truong (dttam2) on 2017-11-01
summary: - Make comment public
+ Can't choose which comment to make public
David Truong (dttam2) on 2017-11-01
description: updated
Robert Lyon (robertl-9) on 2017-11-06
Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
importance: Undecided → High
status: New → Confirmed
Changed in mahara:
status: Confirmed → In Progress
Niranjan (niranjan528) wrote :

URL: https://bugs.launchpad.net/mahara/+bug/1729423

Bug description: Can't choose which comment to make public

Environment to be tested: Master
Browser to be tested: Any browser

Precondition:
1. Normal users ‘User one’ and ‘User two’ should exist.
2. 'User one' created page 'Page 03' and shared it with 'User two'.
3. 'User one' created collection 'Collection' that contains pages 'Page 01' and 'Page 02' and shared it with 'User two'.

Steps to reproduce:

1. Log in as a ‘User two’.
2. On the dashboard under ‘Latest changes I can view’ click on the ‘Page 03’.
3. Enter ‘This is Comment 1’ in the ‘Add comment’ edit box.
4. Switch ‘Make comment public’ to ‘No’.
5. Click the ‘Comment’ button.

Expected result: The comment should display the text ‘This comment is private’ and a link ‘Make comment public’.

6. Similarly set up 12 more private comments.

Expected result: Comments pagination should be displayed and all comments are private.

7. Click the ‘Make comment Public’ link for the second comment.

Expected result: The second comment should display as a public comment and the first comment ‘This is comment 1’ should remain private.

8. Click on the second page of the comments.
9. Click the ‘Make comment Public’ link for the second comment on the second paginated page.

Expected result: The second comment on the second paginated page should display as a public comment. All comments but this one and the second comment on the
first page should still be private.

10. Click the ‘Make comment Public’ button for the first comment on the second paginated page.

Expected result: The first comment on the second paginated page should display as a public comment. Comments 2 on the first and second page should also still be public, and the rest of the comments should remain private.

11. Log out as 'User two' and log in as 'User one'.
12. Navigate to Main menu > Portfolio > Pages and collections.
13. Click the ‘Collection one’.
14. Select ‘Page 02’ from ‘Navigate to page’ drop down.
15. Set up 3 private comments.
16. Click the ‘Make comment public’ link for the second comment.

Expected result: The second comment should display as a public comment and the first and third comments should remain private.

17. Click the ‘Make comment public’ link for the first comment.

Expected result: The first and second comments should display as a public comment and the third comment should remain private.

Reviewed: https://reviews.mahara.org/8257
Committed: https://git.mahara.org/mahara/mahara/commit/9f98b2d7542be8714ba60aa2f1e0e6c4402ff821
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9f98b2d7542be8714ba60aa2f1e0e6c4402ff821
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Nov 6 16:04:47 2017 +1300

Bug 1729423: publish correct private comment in the list

similar to bug 1486763

behatnotneeded

Change-Id: Iaa6e337434996303208a0445099825797e65ae3e

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8270

Reviewed: https://reviews.mahara.org/8269
Committed: https://git.mahara.org/mahara/mahara/commit/4cafb30114036df3a6702f2285feff972b8bdea6
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 4cafb30114036df3a6702f2285feff972b8bdea6
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Nov 6 16:04:47 2017 +1300

Bug 1729423: publish correct private comment in the list

similar to bug 1486763

behatnotneeded

Change-Id: Iaa6e337434996303208a0445099825797e65ae3e
(cherry picked from commit 9f98b2d7542be8714ba60aa2f1e0e6c4402ff821)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8270
Committed: https://git.mahara.org/mahara/mahara/commit/79147d255633079970babc9293321d99cf347f42
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 79147d255633079970babc9293321d99cf347f42
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Nov 6 16:04:47 2017 +1300

Bug 1729423: publish correct private comment in the list

similar to bug 1486763

behatnotneeded

Change-Id: Iaa6e337434996303208a0445099825797e65ae3e
(cherry picked from commit 9f98b2d7542be8714ba60aa2f1e0e6c4402ff821)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers