Bug #1729423 “Can't choose which comment to make public” : Bugs : Mahara

David Truong (dttam2) on 2017-11-01

summary:

- Make comment public
+ Can't choose which comment to make public

David Truong (dttam2) on 2017-11-01

description:

updated

Robert Lyon (robertl-9) on 2017-11-06

Changed in mahara:
assignee:	nobody → Cecilia Vela Gurovic (ceciliavg)

Cecilia Vela Gurovic (ceciliavg) on 2017-11-06

Changed in mahara:
importance:	Undecided → High
status:	New → Confirmed

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2017-11-06: A patch has been submitted for review

#1

Patch for "master" branch: https://reviews.mahara.org/8257

Cecilia Vela Gurovic (ceciliavg) on 2017-11-06

Changed in mahara:
status:	Confirmed → In Progress

Revision history for this message

Niranjan (niranjan528) wrote on 2017-11-09:

#2

URL: https://bugs.launchpad.net/mahara/+bug/1729423

Bug description: Can't choose which comment to make public

Environment to be tested: Master
Browser to be tested: Any browser

Precondition:
1. Normal users ‘User one’ and ‘User two’ should exist.
2. 'User one' created page 'Page 03' and shared it with 'User two'.
3. 'User one' created collection 'Collection' that contains pages 'Page 01' and 'Page 02' and shared it with 'User two'.

Steps to reproduce:

1. Log in as a ‘User two’.
2. On the dashboard under ‘Latest changes I can view’ click on the ‘Page 03’.
3. Enter ‘This is Comment 1’ in the ‘Add comment’ edit box.
4. Switch ‘Make comment public’ to ‘No’.
5. Click the ‘Comment’ button.

Expected result: The comment should display the text ‘This comment is private’ and a link ‘Make comment public’.

6. Similarly set up 12 more private comments.

Expected result: Comments pagination should be displayed and all comments are private.

7. Click the ‘Make comment Public’ link for the second comment.

Expected result: The second comment should display as a public comment and the first comment ‘This is comment 1’ should remain private.

8. Click on the second page of the comments.
9. Click the ‘Make comment Public’ link for the second comment on the second paginated page.

Expected result: The second comment on the second paginated page should display as a public comment. All comments but this one and the second comment on the
first page should still be private.

10. Click the ‘Make comment Public’ button for the first comment on the second paginated page.

Expected result: The first comment on the second paginated page should display as a public comment. Comments 2 on the first and second page should also still be public, and the rest of the comments should remain private.

11. Log out as 'User two' and log in as 'User one'.
12. Navigate to Main menu > Portfolio > Pages and collections.
13. Click the ‘Collection one’.
14. Select ‘Page 02’ from ‘Navigate to page’ drop down.
15. Set up 3 private comments.
16. Click the ‘Make comment public’ link for the second comment.

Expected result: The second comment should display as a public comment and the first and third comments should remain private.

17. Click the ‘Make comment public’ link for the first comment.

Expected result: The first and second comments should display as a public comment and the third comment should remain private.