Edit access screen needs to check if data is saved before leaving
Bug #1693061 reported by
Cecilia Vela Gurovic
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Fix Released
|
High
|
Cecilia Vela Gurovic | ||
Bug Description
In the Share | Edit access screen (/view/
This should not happen, a message needs to be display for us to confirm if we want to leave and lose the changes, or stay and continue working.
| Changed in mahara: | |
| assignee: | nobody → Cecilia Vela Gurovic (ceciliavg) |
| importance: | Undecided → High |
| milestone: | none → 17.10.0 |
Revision history for this message
| Cecilia Vela Gurovic (ceciliavg) wrote | #1 |
| Changed in mahara: | |
| status: | New → In Progress |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #2 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A change has been merged | #3 |
| Changed in mahara: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #4 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A change has been merged | #5 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #6 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A change has been merged | #7 |
| Changed in mahara: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
To check if we have unsaved changes in a pieform we use the FormChangeChecker defined in js/formchangech
This function just checks the changes we make in each <input> element inside the form.
In all other pieform elements, there are hidden input tags that are checked by the FormChangeChecker.
But this is not the case of the selects used in the Edit access screen. They don't have any hidden <input> so the FormChangeChecker won't not say anything when we try lo leave the page.