Comment 2 for bug 1539322

Revision history for this message
Aaron Wells (u-aaronw) wrote : Re: Do we still need device detection?

The latest version of TinyMCE works fine in our supported range of mobile OS'es. The export tab was disabled, I think, because in iOS there'd be no place for the download to go. I'm not sure whether that's still true, but it certainly works fine for Android.

For most of the other situations where we might want to change our behavior depending on the device, we've farmed that complexity out to a third-party library that does its own sniffing and decision making (i.e. mediaplayer, pdfjs, jQuery, etc).

There are two remaining things I think we might want device detection for... and they match up pretty closely with the two current things we do:

1. TinyMCE: Works fine in mobile, but I think we might want to change the layout of the buttons to fit on a mobile browser better. If we could do that in a responsive way that would be best, but otherwise, using device detection might be a good way to handle it.

2. The export tab. Can iOS handle download of ZIP files? If not, then we still need to detect iOS in order to hide it.

However, I think we could at least remove the settings related to device detection. So no more "disable device detection" user preference, and no "allow device detection" site setting. Instead, we'll just detect devices automatically. And if a power-user wants to get the desktop version of the site, they can change their browser's user-agent. (Or maybe replace the "allow device detection" setting with a "show desktop site" setting.)