Remove mobile device detection
Bug #1539322 reported by
Kristina Hoeppner
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Lisa Seeto |
Bug Description
Mahara 15.10 introduced Bootstrap. All themes are now responsive. When I tested the "Deactivate device detection" functionality, I couldn't see much of a difference when using the site. I did notice the content chooser was displayed the start of the words instead of only showing the icon on the "Edit page" screen.
I wonder if we can remove the custom device detection. You can enable the user turning off device detection in Admin -> Config site -> User settings -> Users can disable device detection. That then happens on the account settings page.
summary: |
- Do we still need devicee detection? + Do we still need device detection? |
Changed in mahara: | |
milestone: | 16.04.0 → 16.10.0 |
Changed in mahara: | |
milestone: | 16.10.0 → 16.10.1 |
Changed in mahara: | |
milestone: | 16.10.1 → 17.04.0 |
Changed in mahara: | |
milestone: | 17.04.0 → 17.10.0 |
Changed in mahara: | |
milestone: | 17.10.0 → 18.04.0 |
Changed in mahara: | |
milestone: | 18.04.0 → 18.10.0 |
Changed in mahara: | |
milestone: | 18.10.0 → 19.04.0 |
Changed in mahara: | |
milestone: | 19.04.0 → none |
Changed in mahara: | |
status: | Triaged → In Progress |
Changed in mahara: | |
assignee: | nobody → Lisa Seeto (lisaseeto) |
Changed in mahara: | |
status: | In Progress → Fix Committed |
tags: | added: manualupdate newfeature |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Currently, device detection does two things:
1. Disables TinyMCE
2. Hides the "Portfolio -> Export" navigation tab
There is also code in htdocs/lib/web.php, in the smarty() function, which looks at the results of device detection and puts them into some Smarty template variables. But since 15.10, we no longer actually read those Smarty variables, at least not in any of the core themes.
1. $HANDHELD_DEVICE
2. $MOBILE
3. $DROPDOWNMENU (to disable dropdown menus; in 15.10 we show them anyway)