Collection navigation triggering swiperight event on mouse click

Bug #1749308 reported by Ghada El-Zoghbi
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic

Bug Description

Mahara: 17.10.3
OS: Linux 16.04
DB: Postgres (not relevant)
Browser: Firefox and Chrome

In a collection on a view with the 'Previous page' displayed, the swiperight event is getting triggered on a mouse click.

When a user tries to select some text (i.e. click mouse, hold it down, and select text), this action is interpreted as a swipe action. And, the swiperight event is triggered.

I've come across this stackoverflow discussion:

https://stackoverflow.com/questions/36317660/jquery-mobile-swipe-gesture-for-touch-screen-only-and-not-for-mouse

Bascially, the swiperight and swipeleft events should be disabled on the mousedown event and enabled on the touchstart event.

Tags: snack-sized
Changed in mahara:
status: New → Confirmed
importance: Undecided → Medium
Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 18.10.0
Changed in mahara:
milestone: 18.10.0 → 19.04.0
Changed in mahara:
milestone: 19.04.0 → none
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Once this is fixed, we might be able to remove device detection in bug #1539322

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Work-around for still selecting text:
- double-click for a word
- triple-click for a paragraph

Hat tip to Eric Breton at https://mahara.org/interaction/forum/topic.php?id=8413&post=33591

tags: added: snack-sized
Changed in mahara:
assignee: nobody → Rebecca Blundell (rjb-dev)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10757

Changed in mahara:
assignee: Rebecca Blundell (rjb-dev) → nobody
milestone: none → 20.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/11075

Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11075
Committed: https://git.mahara.org/mahara/mahara/commit/4f4ab38ded7b59a2c92816ef8acc67c9a7464334
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4f4ab38ded7b59a2c92816ef8acc67c9a7464334
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jul 20 16:52:15 2020 +1200

Bug 1749308: Add collection swipe events if on touch device

behatnotneeded

Change-Id: Icf8b861c6d2e6f3b9f0775b5b3c35aa3783accc5

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.