commit 441aa7f2f9b78ef66af8f5c60b2f221b962fbf30
Author: Robert Lyon <email address hidden>
Date: Mon Oct 7 09:09:02 2013 +1300
Creation of new blocktype 'comment' (bug #1245679)
- allow the feedback to display in a block.
Things to note:
1) The feedback block is only to display view's comments on the
view/view.php page and NOT on view/artefact.php page.
2) When in edit mode (view/blocks.php) the feedback block just
displays a 'holder' message
3) When feedback block is on page the feedback does not display at
base of page anymore and when one clicks the 'Place feedback' link the
feedback form pops up over everything similar to how editing a block
works.
4) As the feedback block only works/displays on the view page I have
not fully integrated all the stuff that feedback creates ie js/form
into the blocktype. I have left the view/view.php to do the js and
render form - and simply position the form on the page with js.
This means that if js is off the edit form will still be in it's
old place. I felt this was ok because if js is off and the form was
in the block it could mean things been too squashy if there was lots
of columns.
Reviewed: https:/ /reviews. mahara. org/2668 gitorious. org/mahara/ mahara/ commit/ 441aa7f2f9b78ef 66af8f5c60b2f22 1b962fbf30
Committed: http://
Submitter: Son Nguyen (<email address hidden>)
Branch: master
commit 441aa7f2f9b78ef 66af8f5c60b2f22 1b962fbf30
Author: Robert Lyon <email address hidden>
Date: Mon Oct 7 09:09:02 2013 +1300
Creation of new blocktype 'comment' (bug #1245679)
- allow the feedback to display in a block.
Things to note:
1) The feedback block is only to display view's comments on the
view/view.php page and NOT on view/artefact.php page.
2) When in edit mode (view/blocks.php) the feedback block just
displays a 'holder' message
3) When feedback block is on page the feedback does not display at
base of page anymore and when one clicks the 'Place feedback' link the
feedback form pops up over everything similar to how editing a block
works.
4) As the feedback block only works/displays on the view page I have
not fully integrated all the stuff that feedback creates ie js/form
into the blocktype. I have left the view/view.php to do the js and
render form - and simply position the form on the page with js.
This means that if js is off the edit form will still be in it's
old place. I felt this was ok because if js is off and the form was
in the block it could mean things been too squashy if there was lots
of columns.
Change-Id: I1edaa886c5a0df 1f6feb24bcdd6d8 878a833d673