Place feedback for a view in a block rather at base of page

Bug #1245679 reported by Robert Lyon on 2013-10-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Wishlist
Robert Lyon

Bug Description

Feedback for a page can currently only be placed at the bottom of a page.

However, it would be useful if feedback could be placed elsewhere.

It would be good to have a comment blocktype allowing one to add a comment block to a page making the feedback display in the block's position rather than at the base of the page.

Robert Lyon (robertl-9) wrote :

have added a patch for this:
https://reviews.mahara.org/#/c/2668/

Things to note:
1) The feedback block is only to display view's comments on the
view/view.php page and NOT on view/artefact.php page.

2) When in edit mode (view/blocks.php) the feedback block just
displays a 'holder' message

3) When feedback block is on page the feedback does not display at
base of page anymore and when one clicks the 'Place feedback' link the
feedback form pops up over everything similar to how editing a block
works.

4) As the feedback block only works/displays on the view page I have
not fully integrated all the stuff that feedback creates ie js/form
into the blocktype. I have left the view/view.php to do the js and
render form - and simply position the form on the page with js.

This means that if js is off the edit form will still be in it's
old place. I felt this was ok because if js is off and the form was
in the block it could mean things been too squashy if there was lots
of columns.

Reviewed: https://reviews.mahara.org/2668
Committed: http://gitorious.org/mahara/mahara/commit/441aa7f2f9b78ef66af8f5c60b2f221b962fbf30
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 441aa7f2f9b78ef66af8f5c60b2f221b962fbf30
Author: Robert Lyon <email address hidden>
Date: Mon Oct 7 09:09:02 2013 +1300

Creation of new blocktype 'comment' (bug #1245679)

- allow the feedback to display in a block.

Things to note:
1) The feedback block is only to display view's comments on the
view/view.php page and NOT on view/artefact.php page.

2) When in edit mode (view/blocks.php) the feedback block just
displays a 'holder' message

3) When feedback block is on page the feedback does not display at
base of page anymore and when one clicks the 'Place feedback' link the
feedback form pops up over everything similar to how editing a block
works.

4) As the feedback block only works/displays on the view page I have
not fully integrated all the stuff that feedback creates ie js/form
into the blocktype. I have left the view/view.php to do the js and
render form - and simply position the form on the page with js.

This means that if js is off the edit form will still be in it's
old place. I felt this was ok because if js is off and the form was
in the block it could mean things been too squashy if there was lots
of columns.

Change-Id: I1edaa886c5a0df1f6feb24bcdd6d8878a833d673

Changed in mahara:
status: In Progress → Fix Committed
tags: added: nominatedfeature

Reviewed: https://reviews.mahara.org/3126
Committed: http://gitorious.org/mahara/mahara/commit/b34277b7305aab4ca6aaba85fff36df43a805e68
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b34277b7305aab4ca6aaba85fff36df43a805e68
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Thu Mar 27 19:43:05 2014 +1300

Change lang string for feedback display block (Bug 1245679)

Small change to the text displayed on the edit screen
in the feedback block to make it read easier and to
avoid using the term "footer" as the feedback is not
displayed in the footer but above it.

Change-Id: Ib2cae7bae14df2a4b9d7079ad200fb8deb39fc3e
Signed-off-by: Kristina D.C. Hoeppner <email address hidden>

Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released

This feature was sponsored by New York Institute of Technology.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers