Comment 0 for bug 698305

Revision history for this message
Robert Collins (lifeless) wrote :

This may be on the wrong project, but - we're seeing OOPSes from loggerhead on simple url hacking:

URL: http://bazaar.launchpad.net/%7Eubuntu-branches/ubuntu/lucid/langpack-locales/lucid/revision/64

  Module paste.deploy.config, line 285, in __call__
    return self.app(environ, start_response)
  Module __main__, line 149, in wrapped
  Module paste.wsgilib, line 179, in catch_errors
    app_iter = application(environ, start_response)
  Module launchpad_loggerhead.session, line 53, in __call__
    return self.cookie_handler(environ, start_response)
  Module paste.auth.cookie, line 305, in __call__
    return self.application(environ, response_hook)
  Module launchpad_loggerhead.session, line 80, in _process
    return self.application(environ, response_hook)
  Module paste.httpexceptions, line 636, in __call__
    return self.application(environ, start_response)
  Module launchpad_loggerhead.app, line 228, in __call__
    return view.app(environ, start_response)
  Module loggerhead.apps.branch, line 167, in app
    return c(environ, start_response)
  Module loggerhead.controllers, line 93, in __call__
    vals.update(self.get_values(path, kwargs, headers))
  Module loggerhead.controllers.revision_ui, line 45, in get_values
    revid = self.get_revid()
  Module loggerhead.controllers, line 115, in get_revid
    return h.fix_revid(self.args[0])
  Module loggerhead.history, line 453, in fix_revid
    raise bzrlib.errors.NoSuchRevision(self._branch_nick, revid)
NoSuchRevision: langpack-locales has no revision 64

This should return an error page to the user and not go boom.