no such revision triggers an OOPS
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
loggerhead |
Fix Released
|
High
|
Max Kanat-Alexander |
Bug Description
This may be on the wrong project, but - we're seeing OOPSes from loggerhead on simple url hacking:
OOPS-1832CBB6802 for instance
URL: http://
Module paste.deploy.
return self.app(environ, start_response)
Module __main__, line 149, in wrapped
Module paste.wsgilib, line 179, in catch_errors
app_iter = application(
Module launchpad_
return self.cookie_
Module paste.auth.cookie, line 305, in __call__
return self.applicatio
Module launchpad_
return self.applicatio
Module paste.httpexcep
return self.applicatio
Module launchpad_
return view.app(environ, start_response)
Module loggerhead.
return c(environ, start_response)
Module loggerhead.
vals.
Module loggerhead.
revid = self.get_revid()
Module loggerhead.
return h.fix_revid(
Module loggerhead.history, line 453, in fix_revid
raise bzrlib.
NoSuchRevision: langpack-locales has no revision 64
This should return an error page to the user and not go boom.
Related branches
- Michael Hudson-Doyle: Approve
-
Diff: 31 lines (+8/-2)1 file modifiedloggerhead/controllers/__init__.py (+8/-2)
- Brad Crittenden (community): Approve (code)
- Launchpad PQM Bot: Pending requested
-
Diff: 27 lines (+8/-2)1 file modifiedloggerhead/controllers/__init__.py (+8/-2)
Changed in loggerhead: | |
assignee: | nobody → Max Kanat-Alexander (mkanat) |
Changed in loggerhead: | |
status: | Triaged → In Progress |
Changed in loggerhead: | |
status: | Fix Committed → Fix Released |
This could happen without URL hacking, if someone follows a link that was made before an uncommit or push --overwrite or even branch renames.