Launchpad itself

  1. Bug #851562
  2. Comment #2

Comment 2 for bug 851562

Revision history for this message
Colin Watson (cjwatson) wrote : Re: Diff's not available for sync's on +queue page like for regular uploads

I've been looking at this a bit. Generating the diff in time is easy (actually easier than doing it in its current position, I think), but showing it is hard because diffs are linked to SPRs and PCJs don't have a fixed SPR.

I wonder if it would be terrible to just add an optional SPR reference to the PCJ table, so that we could use that to look up PackageDiffs as needed? We don't always have an SPR in hand (e.g. in DistroSeriesLocalDifferencesView.requestUpgrades), but as far as I can see the cases where we don't have one when creating the PCJ don't matter for queue reviews.