Diffs not available for syncs on +queue page like for regular uploads
Bug #851562 reported by
Scott Kitterman
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
High
|
Unassigned |
Bug Description
As you can see from the attached screen shot, we have diffs available on pages like https:/
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: derivation |
tags: | added: package-copies package-diff |
summary: |
- Diff's not available for sync's on +queue page like for regular uploads + Diffs not available for syncs on +queue page like for regular uploads |
To post a comment you must log in.
I've been looking at this a bit. Generating the diff in time is easy (actually easier than doing it in its current position, I think), but showing it is hard because diffs are linked to SPRs and PCJs don't have a fixed SPR.
I wonder if it would be terrible to just add an optional SPR reference to the PCJ table, so that we could use that to look up PackageDiffs as needed? We don't always have an SPR in hand (e.g. in DistroSeriesLoc alDifferencesVi ew.requestUpgra des), but as far as I can see the cases where we don't have one when creating the PCJ don't matter for queue reviews.