Provide a way to start doing a review by email from web page.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
Low
|
Unassigned |
Bug Description
So I'm looking at a merge proposal that I am not yet a reviewer on, but I
would like to review the branch, or an incremental diff in a comment. I'd
greatly prefer to do my review via email. When I look at the mp, I see my
name under the previous reviewers, but my name is grayed out and i see a link
under the status called [Review]. I also see a (+) Request another review
button.
My natural inclination is to click on the [Review] link, thinking this will
set me up as a Reviewer for the branch, and send me emails containing all the
comment so far. Instead, this link does what it says it does <wink> not what
I want it to do! It gives me a comment field and a status pull down for me to
actually do the review. But at that moment, I don't want to do the review, I
want it to send me the email so I can do the review.
Of course, clicking on (+) Request another review is what I really want to do,
and once I've done that, I'm into the workflow I expect. I think at a minimum
the u/i is leading me down the wrong path here.
Changed in launchpad-bazaar: | |
importance: | Undecided → Medium |
status: | New → Triaged |
summary: |
- workflow/ui nit in merge proposals + Provide a way to start doing a review by email from web page. |
tags: | added: email |
Changed in launchpad: | |
importance: | Medium → Low |
Well, actually no, requesting myself as another reviewer doesn't send me the emails, which is what I really want!