Advanced subscription overlay for direct subscriptions does not handle unsubscribing teams

[Brad Crittenden]

The overlay has an option for unsubscribing a team but the logic does not support it. In fact, selecting an option like "Unsubscribe HWDB team" will actually unsubscribe the user, leaving the team subscribed.

[Данило Шеган (danilo)]

Ok, when working on this, I found out a gazillion of problems. I'll list those that I haven't fixed yet here just so I have them written down, and I'll be filing bugs as appropriate.

 1. There is no 'mute' link if you are a member of a team that is subscribed to the bug
 2. Animation for show-bug-notification-levels is conditional on your subscription being "muted" in bug_subscription.js and bug-subscription.pt when it shouldn't be, since we don't want to show levels for unsubscribing teams either; I might fix this in this branch
 3. There is no way to set a different bug notification level for team subscriptions
 4. For the "update my subscription level" radio box we hard-code "update-subscription" as the value, which might just as well be a team/person name, and if such a person/team ever shows up, it's all going to break
 5. If at any one point you end up with no subscribers after you've unsubscribed everyone, "subscribing someone else" fails from then on; this is not a problem if you start with a bug with no subscribers, so the "None" text that is being added doesn't have the same properties as the one that's originally constructed on page load
 6. There are no tests at all for this

I am fixing a few other problems except the one mentioned in this bug: animation was very jumpy if you click the same radio box twice, and when you had a bug muted, you couldn't really set the bug notification level when unmuting.

[Данило Шеган (danilo)]

Also, 7. Mute link doesn't show up when you eg. assign yourself to a bug (you have to refresh the page to see it)

[Данило Шеган (danilo)]

By order of priority, IMO:
 Must fix: 2, 5
 Should: 6, 4
 Nice: 1, 3, 7

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12909 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12909>.

[Данило Шеган (danilo)]

This is good to be rolled out, but I found a few more problems:
 - animation is still borked, and behaves even stranger in firefox
 - teams from duplicates are shown as "unsubscribe this team" option, but unsubscribing them doesn't work

[Данило Шеган (danilo)]

Issue 2 (and all animation related stuff) filed as bug 770239, problem 5 as bug 770241, problem 4 as bug 770249 and my previous point about team dupe subs from comment #5 as bug 770245.