Launchpad itself

Oops calling view/isRedirectInhibited from non-launchpadview

Bug #538207 reported by Colin Watson
46
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Guilherme Salgado
Launchpad itself 10.03

Bug Description

- We will move isRedirectInhibited from the LaunchpadView to the request class.

- We will then change the TAL from view/isRedirectInhibited to request/isRedirectInhibited. That should work in all cases.

ORIGINAL REPORT
I created a new team 'ubuntu-cli-mono-dev', added 'developer-membership-board' as a member, and tried to edit its membership to set it as an administrator, taking me to this page:

  https://edge.launchpad.net/~ubuntu-cli-mono-dev/+member/developer-membership-board

This gave me an "Oops!" page, but, weirdly, without a visible OOPS ID (screenshot attached). Viewing source reveals that something seems to be getting confused just before <body>, and the ID is OOPS-1532EC941.

    LocationError: (<zope.browserpage.metaconfigure.SimpleViewClass from /srv/edge.launchpad.net/edge/launchpad-rev-10492/lib/lp/registry/browser/../templates/teammembership-index.pt object at 0x966de50>, 'isRedirectInhibited')

See original description

Related branches

lp:~salgado/launchpad/bug-538207
Aaron Bentley (community): Approve
Diff: 135 lines (+23/-20)
6 files modified
lib/canonical/launchpad/doc/launchpadview.txt (+0/-10)
lib/canonical/launchpad/templates/oops.pt (+1/-1)
lib/canonical/launchpad/webapp/publisher.py (+0/-4)
lib/canonical/launchpad/webapp/servers.py (+5/-1)
lib/canonical/launchpad/webapp/tests/test_servers.py (+15/-2)
lib/lp/app/templates/base-layout-macros.pt (+2/-2)
Revision history for this message
Colin Watson (cjwatson) wrote :
Revision history for this message
Colin Watson (cjwatson) wrote :

I retried on production and it works fine there.

Curtis Hovey (sinzui)
summary: - oops when trying to change developer-membership-board to be an
- administrator of ubuntu-cli-mono-dev
+ Opps calling view/isRedirectInhibited from non-launchpadview
affects: launchpad-registry → launchpad-foundations
Revision history for this message
Curtis Hovey (sinzui) wrote : Re: Opps calling view/isRedirectInhibited from non-launchpadview

I favor fixing the views, but I think we need to get several teams involved, and that may not be enough to handle views that are defined in ZCML directives

description: updated
Changed in launchpad-foundations:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Gary Poster (gary) wrote :

Curtis and I talked, and he seemed to be fine with the following solution.

- We will move isRedirectInhibited from the LaunchpadView to the request class.

- We will then change the TAL from view/isRedirectInhibited to request/isRedirectInhibited. That should work in all cases.

I'll schedule for early next week.

Changed in launchpad-foundations:
assignee: nobody → Gary Poster (gary)
milestone: none → 10.03
summary: - Opps calling view/isRedirectInhibited from non-launchpadview
+ Oops calling view/isRedirectInhibited from non-launchpadview
Revision history for this message
Данило Шеган (danilo) wrote :

Please open a 'rosetta' task if you can't fix this early this week: week after that won't work for us if we end up needing to fix up views later (i.e. you decide that moving it to a request object is not the way to go).

Revision history for this message
David Planella (dpm) wrote :

Related to this, on the Rosetta oopses I've seen, on Firefox the oops page is a completely blank one with a "Return to the Launchpad front page" link. The "Disable edge redirect" box is not shown there.

The same oops page with Epiphany (webkit) shows the "Disable edge redirect" box just fine.

This can be a blocker for translators using edge (or other users if some other pages display the same behaviour), since it is not obvious how to disable the edge redirection anymore (the redirect notice is not shown on https://edge.launchpad.net/, either)

Ursula Junque (ursinha)
tags: added: oops
description: updated
Revision history for this message
Gary Poster (gary) wrote :

This will be started today (me or salgado), and hopefully finished tomorrow.

description: updated
Guilherme Salgado (salgado)
Changed in launchpad-foundations:
assignee: Gary Poster (gary) → Guilherme Salgado (salgado)
Revision history for this message
Guilherme Salgado (salgado) wrote :

I'll make sure the link for disabling edge redirect is shown on firefox as well.

Guilherme Salgado (salgado)
Changed in launchpad-foundations:
status: Triaged → In Progress
Guilherme Salgado (salgado)
Changed in launchpad-foundations:
status: In Progress → Fix Committed
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10522 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10522>

tags: added: qa-needstesting
Guilherme Salgado (salgado)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 538207 Fix released

Fixed released in launchpad-project 10.03.

Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.