| 2010-03-12 18:56:27 |
Colin Watson |
bug |
|
|
added bug |
| 2010-03-12 18:56:27 |
Colin Watson |
attachment added |
|
oops.png http://launchpadlibrarian.net/40883922/oops.png |
|
| 2010-03-12 21:27:06 |
Curtis Hovey |
summary |
oops when trying to change developer-membership-board to be an administrator of ubuntu-cli-mono-dev |
Opps calling view/isRedirectInhibited from non-launchpadview |
|
| 2010-03-12 21:27:15 |
Curtis Hovey |
affects |
launchpad-registry |
launchpad-foundations |
|
| 2010-03-12 21:38:41 |
Curtis Hovey |
description |
I created a new team 'ubuntu-cli-mono-dev', added 'developer-membership-board' as a member, and tried to edit its membership to set it as an administrator, taking me to this page:
https://edge.launchpad.net/~ubuntu-cli-mono-dev/+member/developer-membership-board
This gave me an "Oops!" page, but, weirdly, without a visible OOPS ID (screenshot attached). Viewing source reveals that something seems to be getting confused just before <body>, and the ID is OOPS-1532EC941. |
Not all browser views are launchpad views so isRedirectInhibited is not provided. Some like TeamMembershipEditView do not decend from Launchpadview. Some views are implicitly created in ZCML directives. I am not sure how we want to fix this. This specific instance of oops can be fixed by changing TeamMembershipEditView, but I see more than 15 other views in browser/* that will also oops. We could make the taled more robust using not:view/isRedirectInhibited|nothing.
ORIGINAL REPORT
I created a new team 'ubuntu-cli-mono-dev', added 'developer-membership-board' as a member, and tried to edit its membership to set it as an administrator, taking me to this page:
https://edge.launchpad.net/~ubuntu-cli-mono-dev/+member/developer-membership-board
This gave me an "Oops!" page, but, weirdly, without a visible OOPS ID (screenshot attached). Viewing source reveals that something seems to be getting confused just before <body>, and the ID is OOPS-1532EC941.
|
|
| 2010-03-12 21:38:48 |
Curtis Hovey |
launchpad-foundations: status |
New |
Triaged |
|
| 2010-03-12 21:38:51 |
Curtis Hovey |
launchpad-foundations: importance |
Undecided |
High |
|
| 2010-03-12 21:50:38 |
Gary Poster |
launchpad-foundations: milestone |
|
10.03 |
|
| 2010-03-12 21:50:38 |
Gary Poster |
launchpad-foundations: assignee |
|
Gary Poster (gary) |
|
| 2010-03-12 21:51:10 |
Gary Poster |
summary |
Opps calling view/isRedirectInhibited from non-launchpadview |
Oops calling view/isRedirectInhibited from non-launchpadview |
|
| 2010-03-15 13:10:03 |
Ursula Junque |
tags |
|
oops |
|
| 2010-03-15 13:10:17 |
Ursula Junque |
description |
Not all browser views are launchpad views so isRedirectInhibited is not provided. Some like TeamMembershipEditView do not decend from Launchpadview. Some views are implicitly created in ZCML directives. I am not sure how we want to fix this. This specific instance of oops can be fixed by changing TeamMembershipEditView, but I see more than 15 other views in browser/* that will also oops. We could make the taled more robust using not:view/isRedirectInhibited|nothing.
ORIGINAL REPORT
I created a new team 'ubuntu-cli-mono-dev', added 'developer-membership-board' as a member, and tried to edit its membership to set it as an administrator, taking me to this page:
https://edge.launchpad.net/~ubuntu-cli-mono-dev/+member/developer-membership-board
This gave me an "Oops!" page, but, weirdly, without a visible OOPS ID (screenshot attached). Viewing source reveals that something seems to be getting confused just before <body>, and the ID is OOPS-1532EC941.
|
Not all browser views are launchpad views so isRedirectInhibited is not provided. Some like TeamMembershipEditView do not decend from Launchpadview. Some views are implicitly created in ZCML directives. I am not sure how we want to fix this. This specific instance of oops can be fixed by changing TeamMembershipEditView, but I see more than 15 other views in browser/* that will also oops. We could make the taled more robust using not:view/isRedirectInhibited|nothing.
ORIGINAL REPORT
I created a new team 'ubuntu-cli-mono-dev', added 'developer-membership-board' as a member, and tried to edit its membership to set it as an administrator, taking me to this page:
https://edge.launchpad.net/~ubuntu-cli-mono-dev/+member/developer-membership-board
This gave me an "Oops!" page, but, weirdly, without a visible OOPS ID (screenshot attached). Viewing source reveals that something seems to be getting confused just before <body>, and the ID is OOPS-1532EC941.
LocationError: (<zope.browserpage.metaconfigure.SimpleViewClass from /srv/edge.launchpad.net/edge/launchpad-rev-10492/lib/lp/registry/browser/../templates/teammembership-index.pt object at 0x966de50>, 'isRedirectInhibited')
|
|
| 2010-03-15 14:05:58 |
Gary Poster |
description |
Not all browser views are launchpad views so isRedirectInhibited is not provided. Some like TeamMembershipEditView do not decend from Launchpadview. Some views are implicitly created in ZCML directives. I am not sure how we want to fix this. This specific instance of oops can be fixed by changing TeamMembershipEditView, but I see more than 15 other views in browser/* that will also oops. We could make the taled more robust using not:view/isRedirectInhibited|nothing.
ORIGINAL REPORT
I created a new team 'ubuntu-cli-mono-dev', added 'developer-membership-board' as a member, and tried to edit its membership to set it as an administrator, taking me to this page:
https://edge.launchpad.net/~ubuntu-cli-mono-dev/+member/developer-membership-board
This gave me an "Oops!" page, but, weirdly, without a visible OOPS ID (screenshot attached). Viewing source reveals that something seems to be getting confused just before <body>, and the ID is OOPS-1532EC941.
LocationError: (<zope.browserpage.metaconfigure.SimpleViewClass from /srv/edge.launchpad.net/edge/launchpad-rev-10492/lib/lp/registry/browser/../templates/teammembership-index.pt object at 0x966de50>, 'isRedirectInhibited')
|
- We will move isRedirectInhibited from the LaunchpadView to the request class.
- We will then change the TAL from view/isRedirectInhibited to request/isRedirectInhibited. That should work in all cases.
ORIGINAL REPORT
I created a new team 'ubuntu-cli-mono-dev', added 'developer-membership-board' as a member, and tried to edit its membership to set it as an administrator, taking me to this page:
https://edge.launchpad.net/~ubuntu-cli-mono-dev/+member/developer-membership-board
This gave me an "Oops!" page, but, weirdly, without a visible OOPS ID (screenshot attached). Viewing source reveals that something seems to be getting confused just before <body>, and the ID is OOPS-1532EC941.
LocationError: (<zope.browserpage.metaconfigure.SimpleViewClass from /srv/edge.launchpad.net/edge/launchpad-rev-10492/lib/lp/registry/browser/../templates/teammembership-index.pt object at 0x966de50>, 'isRedirectInhibited')
|
|
| 2010-03-15 14:08:02 |
Guilherme Salgado |
launchpad-foundations: assignee |
Gary Poster (gary) |
Guilherme Salgado (salgado) |
|
| 2010-03-15 17:22:19 |
Guilherme Salgado |
launchpad-foundations: status |
Triaged |
In Progress |
|
| 2010-03-15 17:59:03 |
Guilherme Salgado |
branch linked |
|
lp:~salgado/launchpad/bug-538207 |
|
| 2010-03-16 15:32:52 |
Guilherme Salgado |
launchpad-foundations: status |
In Progress |
Fix Committed |
|
| 2010-03-17 08:16:26 |
Ursula Junque |
tags |
oops |
oops qa-needstesting |
|
| 2010-03-17 12:08:01 |
Guilherme Salgado |
tags |
oops qa-needstesting |
oops qa-ok |
|
| 2010-03-31 15:48:17 |
Curtis Hovey |
launchpad-foundations: status |
Fix Committed |
Fix Released |
|
