Errors are not handled properly in inline multi-line text editing
Bug #415365 reported by
Matthew Paul Thomas
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Guilherme Salgado | ||
Bug Description
If a multi-line text editor widget gets something other than a 200 response from the API call it shows a red border but not the actual error and loses its title. After digging a bit I found out that it's actually setting the error message on the "correct" node's innerHTML but since we're dealing with a multi-line widget the text area appears on top of that so the user never sees the error message.
On single-line text editors we seem to lose the ok/cancel buttons (bug 703061)
Related branches
lp:~salgado/launchpad/bug-415365
- Deryck Hodge (community): Approve
- Richard Harding (community): Approve (code*)
-
Diff: 81 lines (+34/-6)3 files modifiedlib/lp/app/javascript/inlineedit/editor.js (+6/-2)
lib/lp/app/javascript/inlineedit/tests/test_inline_edit.html (+6/-0)
lib/lp/app/javascript/inlineedit/tests/test_inline_edit.js (+22/-4)
Revision history for this message
| Matthew Paul Thomas (mpt) wrote | #1 |
Revision history for this message
| Deryck Hodge (deryck) wrote | #2 |
| description: | updated |
| description: | updated |
| summary: |
- Making zero changes to bug description produces ugly border and - indefinite spinner + Errors are not handled properly in inline description editing |
| Changed in malone: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
Revision history for this message
| Ursula Junque (ursinha) wrote Re: Errors are not handled properly in inline description editing | #3 |
Revision history for this message
| Данило Шеган (danilo) wrote | #4 |
| summary: |
- Errors are not handled properly in inline description editing + Errors are not handled properly in inline text editing |
| description: | updated |
| summary: |
- Errors are not handled properly in inline text editing + Errors are not handled properly in inline multi-line text editing |
| description: | updated |
Revision history for this message
| Guilherme Salgado (salgado) wrote | #5 |
| Changed in launchpad: | |
| assignee: | nobody → Guilherme Salgado (salgado) |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #6 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
There are actually two bugs here -- the ugly border/spinner problem is because submitting the description caused an error. I see a 303 response rather than a 200 on the example mpt sites here. We need to correctly handle errors in submitting.
Not allowing a user to submit an unchanged description is a different issue, and a fix for that will also fix bug 414980.
I'll update the description and title here to reflect that this bug is about handling the error properly and track the other issue at bug 414980.