It is possible to create empty diffs with the new inline description editing

[Markus Korn]

1.) click the yellow pencil to edit the description of a bug
2.) change nothing in the shown up textbox
3.) click the green check to apply the 'new' (infact old) description

This results in a activity log entry and also a notification email with empty diff is send.
See bug 385570 as an example.
As far as I remember in the old way of editing descriptions an empty diff did not result in a notification email and activity log entry.
I think the best solution for this would be to grey out the green check as long as nothing is changed and also do not handle empty diffs here as an activity.

Markus

[Deryck Hodge (deryck)]

mpt's initial suggestions at bug 415365 are a good way to fix this bug.

We should not enable the submit button (the green check) until the description has changed. This will have to be fixed in the lazr-js branch.

This, also, would not be too hard to fix if someone is interested in helping with Launchpad development since both Launchpad's code and lazr-js code are open source. My initial thought is that the fix amounts to deferring the _bindButtons call for C_SUBMIT until someone types in the textarea. I'm available to help any developer who is interested in fixing this.

[Paul Hummer (rockstar)]

I don't think this is a lazr-js issue. It's common to have Ok available even when there are no changes.

[Curtis Hovey (sinzui)]

I updated the fields some months ago to prevent emtpy descriptions because they can cause oopses.