Activity log for bug #415365

Date Who What changed Old value New value Message
2009-08-18 13:00:54 Matthew Paul Thomas bug added bug
2009-08-18 13:00:54 Matthew Paul Thomas attachment added Screenshot.png http://launchpadlibrarian.net/30459779/Screenshot.png
2009-08-18 13:48:26 Deryck Hodge description 1. Go to a bug report page, e.g. <https://staging.launchpad.net/malone/+bug/396406>. 2. Click the edit button for the bug description. 3. Click the confirm button for the bug description. What happens: * An ugly red border appears around the description. * The tab thing containing the edit button breaks into two. * A spinner appears and spins forever. What should happen: * The confirm button should not be clickable until you've actually changed the description, in the same way that the "Post Comment" button is not clickable until you've typed a comment. 1. Go to a bug report page, e.g. <https://staging.launchpad.net/malone/+bug/396406>. 2. Click the edit button for the bug description. 3. Click the confirm button for the bug description. What happens: * An ugly red border appears around the description. * The tab thing containing the edit button breaks into two. * A spinner appears and spins forever. What should happen: * The confirm button should not be clickable until you've actually changed the description, in the same way that the "Post Comment" button is not clickable until you've typed a comment.
2009-08-18 13:50:14 Deryck Hodge description 1. Go to a bug report page, e.g. <https://staging.launchpad.net/malone/+bug/396406>. 2. Click the edit button for the bug description. 3. Click the confirm button for the bug description. What happens: * An ugly red border appears around the description. * The tab thing containing the edit button breaks into two. * A spinner appears and spins forever. What should happen: * The confirm button should not be clickable until you've actually changed the description, in the same way that the "Post Comment" button is not clickable until you've typed a comment. 1. Go to a bug report page, e.g. <https://staging.launchpad.net/malone/+bug/396406>. 2. Click the edit button for the bug description. 3. Click the confirm button for the bug description. What happens: * An ugly red border appears around the description. * The tab thing containing the edit button breaks into two. * A spinner appears and spins forever. * There is a 303 response from the API call, not a 200 What should happen: * The edit widget should flash red * The error should be reported to the user * The edit widget should be reset
2009-08-18 13:51:18 Deryck Hodge summary Making zero changes to bug description produces ugly border and indefinite spinner Errors are not handled properly in inline description editing
2009-08-18 14:02:30 Deryck Hodge malone: status New Triaged
2009-08-18 14:02:36 Deryck Hodge malone: importance Undecided Low
2012-03-01 18:30:47 Guilherme Salgado summary Errors are not handled properly in inline description editing Errors are not handled properly in inline text editing
2012-03-01 18:35:20 Guilherme Salgado description 1. Go to a bug report page, e.g. <https://staging.launchpad.net/malone/+bug/396406>. 2. Click the edit button for the bug description. 3. Click the confirm button for the bug description. What happens: * An ugly red border appears around the description. * The tab thing containing the edit button breaks into two. * A spinner appears and spins forever. * There is a 303 response from the API call, not a 200 What should happen: * The edit widget should flash red * The error should be reported to the user * The edit widget should be reset If the text widget gets something other than a 200 response from the API call it shows a red border but not the actual error. On TextLineEditorWidget we seem to also lose the ok/cancel buttons (bug 703061) whereas on TextAreaEditorWidget the title seems to vanish (see screenshot). (I think these instructions no longer work) 1. Go to a bug report page, e.g. <https://staging.launchpad.net/malone/+bug/396406>. 2. Click the edit button for the bug description. 3. Click the confirm button for the bug description. What happens: * An ugly red border appears around the description. * The tab thing containing the edit button breaks into two. * A spinner appears and spins forever. * There is a 303 response from the API call, not a 200 What should happen: * The edit widget should flash red * The error should be reported to the user * The edit widget should be reset
2012-03-01 18:36:24 Guilherme Salgado bug added subscriber Guilherme Salgado
2012-03-01 19:36:28 Guilherme Salgado summary Errors are not handled properly in inline text editing Errors are not handled properly in inline multi-line text editing
2012-03-01 19:39:53 Guilherme Salgado description If the text widget gets something other than a 200 response from the API call it shows a red border but not the actual error. On TextLineEditorWidget we seem to also lose the ok/cancel buttons (bug 703061) whereas on TextAreaEditorWidget the title seems to vanish (see screenshot). (I think these instructions no longer work) 1. Go to a bug report page, e.g. <https://staging.launchpad.net/malone/+bug/396406>. 2. Click the edit button for the bug description. 3. Click the confirm button for the bug description. What happens: * An ugly red border appears around the description. * The tab thing containing the edit button breaks into two. * A spinner appears and spins forever. * There is a 303 response from the API call, not a 200 What should happen: * The edit widget should flash red * The error should be reported to the user * The edit widget should be reset If a multi-line text editor widget gets something other than a 200 response from the API call it shows a red border but not the actual error and loses its title. After digging a bit I found out that it's actually setting the error message on the "correct" node's innerHTML but since we're dealing with a multi-line widget the text area appears on top of that so the user never sees the error message. On single-line text editors we seem to lose the ok/cancel buttons (bug 703061)
2012-03-01 19:52:16 Launchpad Janitor branch linked lp:~salgado/launchpad/bug-415365
2012-03-01 20:17:21 Guilherme Salgado attachment added overlay-error.png https://bugs.launchpad.net/launchpad/+bug/415365/+attachment/2798570/+files/overlay-error.png
2012-03-01 21:01:18 Guilherme Salgado launchpad: assignee Guilherme Salgado (salgado)
2012-03-01 21:11:36 Guilherme Salgado launchpad: status Triaged In Progress
2012-03-02 12:20:41 Launchpad QA Bot tags lp-bugs lp-bugs qa-needstesting
2012-03-02 12:20:42 Launchpad QA Bot launchpad: status In Progress Fix Committed
2012-03-02 17:26:35 Guilherme Salgado tags lp-bugs qa-needstesting lp-bugs qa-ok
2012-03-05 01:48:13 William Grant launchpad: status Fix Committed Fix Released