Comment 2 for bug 1003748

Revision history for this message
Curtis Hovey (sinzui) wrote :

Attached is a screencap from qastaging using Chromium. There are two issues. The visible issue is that the sprite does not align with the text. This makes sense given that images have different alignment rules and the sprite is attached to an image. The img element is invalid. img must have a src attribute, but this example has just classes designed for inline-text elements and specifically the <a>

Reviewing other examples of editicon class, they use <img class="editicon" src="/@@/edit" /> to do the right thing.

But the easiest fix is to move the "sprite edit" class to the anchor...everything works. The <img> is not needed. I know the editicon class needs to be on an element, so maybe a <span>?

Also, I happen to know that Ian has a branch that changes some of the sprite anchor rules that might fix this, or can easily add the fix.