filebug form choice widgets for importance, info type,

Bug #1003748 reported by Ian Booth
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Ian Booth

Bug Description

The file bug form allows authorised users to enter the bug status, importance and information type. The status and importance use drop down combo controls which don't show the descriptions of each choice. The information type uses a radio button set which takes up space and is inconsistent with the other two.

When javascript is available, the form should be enhanced to use choice source popup widgets for these items.

Related branches

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-bad
removed: qa-needstesting
Revision history for this message
Curtis Hovey (sinzui) wrote :

Attached is a screencap from qastaging using Chromium. There are two issues. The visible issue is that the sprite does not align with the text. This makes sense given that images have different alignment rules and the sprite is attached to an image. The img element is invalid. img must have a src attribute, but this example has just classes designed for inline-text elements and specifically the <a>

Reviewing other examples of editicon class, they use <img class="editicon" src="/@@/edit" /> to do the right thing.

But the easiest fix is to move the "sprite edit" class to the anchor...everything works. The <img> is not needed. I know the editicon class needs to be on an element, so maybe a <span>?

Also, I happen to know that Ian has a branch that changes some of the sprite anchor rules that might fix this, or can easily add the fix.

tags: added: bad-commit-15325
Revision history for this message
Robert Collins (lifeless) wrote :

A revert is landed in rev 15336

Ian Booth (wallyworld)
tags: added: qa-ok
removed: bad-commit-15325 qa-bad
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
tags: added: privacy
Curtis Hovey (sinzui)
tags: added: information-type
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.